Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Switch to opt-in Stardog syntax #13

Merged
merged 1 commit into from
Feb 6, 2024
Merged

[REF] Switch to opt-in Stardog syntax #13

merged 1 commit into from
Feb 6, 2024

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Feb 2, 2024 •
edited by rmanaem
Loading

Changes proposed in this pull request:

  • change --use-graphdb-syntax flag -> --use-stardog-syntax
  • rename inline variable use_graphdb_syntax -> use_stardog_syntax
  • refactor if-statements
  • change default to be graphDB syntax

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

surchs added a commit to neurobagel/documentation that referenced this pull request Feb 2, 2024
@surchs
[REF] update syntax for data upload script
ee27dbe 
Because of neurobagel/recipes#13
we now default to using graphDB syntax. This updates
the docs to show the new behaviour
@surchs surchs mentioned this pull request Feb 2, 2024
Merged
3 tasks
@rmanaem rmanaem self-requested a review February 5, 2024 04:52
rmanaem
rmanaem approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

surchs added a commit to neurobagel/documentation that referenced this pull request Feb 6, 2024
@surchs
[REF] update syntax for data upload script (#160)
6a46e21 
Because of neurobagel/recipes#13
we now default to using graphDB syntax. This updates
the docs to show the new behaviour
@surchs surchs merged commit 03d9e2f into main Feb 6, 2024
@surchs surchs deleted the switch_graphdb branch February 6, 2024 19:08
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

neurobagel-bot bot commented Aug 7, 2024

🚀 PR was released in v0.0.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmanaem rmanaem rmanaem approved these changes

Assignees

@surchs surchs

Labels
released This issue/pull request has been released.
Projects
Neurobagel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surchs @rmanaem