Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Use host-gateway instead of localhost in local federation config #6

Merged
merged 2 commits into from
Dec 19, 2023
Merged

[FIX] Use host-gateway instead of localhost in local federation config #6

merged 2 commits into from
Dec 19, 2023

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Dec 16, 2023 •
edited by surchs
Loading

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@surchs surchs self-requested a review December 18, 2023 20:20
surchs
surchs approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@alyssadai alyssadai merged commit d4918fe into main Dec 19, 2023
@alyssadai alyssadai deleted the add-host-ip branch December 19, 2023 01:24
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

neurobagel-bot bot commented Aug 7, 2024

🚀 PR was released in v0.0.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add internal IP address of host to configs for local federation
2 participants
@alyssadai @surchs