Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick from master to release/8.1 #1736

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Cherry pick from master to release/8.1 #1736

merged 2 commits into from
Mar 25, 2022

Conversation

alexsavulescu
Copy link
Member

Anything else?

bb-c02gx3mmq6lt:nrn savulesc$ git log --pretty=format:"%h: %s" --since="2020-12-18"  release/8.1..master
513d45c52: drop Python 3.6 support (#1733)
4d294685e: NEURON 8.1.0 Changelog (#1724)
d141b7425: ban jinja2@3.1.0 as it's buggy (#1731)
6d82be01d: docs: NetStim random guide; also fix to toctree (#1727)
d0f38d582: UndefinedBehaviourSanitizer fixes (#1479)
6f666ac60: Disallow STATE variables being GLOBAL (#1723)

@alexsavulescu @pramodk
@ramcdougal @adamjhn
NEURON 8.1.0 Changelog (#1724)
3ac003c 
Co-authored-by: Pramod Kumbhar <pramod.s.kumbhar@gmail.com>
Co-authored-by: ramcdougal <robert.mcdougal@yale.edu>
Co-authored-by: adamjhn <adam.newton@yale.edu>
@alexsavulescu
Copy link
Member Author

With this we can release 8.1.0

@alexsavulescu alexsavulescu mentioned this pull request Mar 25, 2022
Closed
15 tasks
@alexsavulescu
Copy link
Member Author

@nrnhines we can apply clang format directly into chg810release branch and into master in another PR.

@pramodk
Copy link
Member

pramodk commented Mar 25, 2022 •
edited
Loading

d141b74: ban jinja2@3.1.0 as it's buggy (#1731)

Do we need to include this in order to address docs building issue? (I don't know docs building workflow/deps though!)

Edit: CI answered it!

@olupton @alexsavulescu
ban jinja2@3.1.0 as it's buggy (#1731)
2832d54 
* module 'jinja2.utils' has no attribute 'escape' sphinx-doc/sphinx#10289
* [BUG] module 'jinja2.utils' has no attribute 'escape' jupyter/nbconvert#1736
@pramodk pramodk closed this Mar 25, 2022
@pramodk pramodk reopened this Mar 25, 2022
@alexsavulescu
Copy link
Member Author

will merge this. we can format post-release

@pramodk
Copy link
Member

pramodk commented Mar 25, 2022

Stucked CI status messages seems to be bogus. So I will go with merge.

@pramodk pramodk merged commit 047dd82 into release/8.1 Mar 25, 2022
@alexsavulescu alexsavulescu deleted the chg810release branch March 27, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pramodk pramodk pramodk approved these changes

@adamjhn adamjhn Awaiting requested review from adamjhn

@nrnhines nrnhines Awaiting requested review from nrnhines

@ramcdougal ramcdougal Awaiting requested review from ramcdougal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexsavulescu @pramodk @olupton