Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

react: Add eslint-plugin-react-hooks #1300

Closed
edmorley opened this issue Feb 11, 2019 · 0 comments
Closed

react: Add eslint-plugin-react-hooks #1300

edmorley opened this issue Feb 11, 2019 · 0 comments
Assignees
@helfi92
Labels
feature
Milestone
Neutrino 9

Comments

@edmorley
Copy link
Member

The new React 16.8 hooks feature recommends that people use the associated eslint plugin to ensure the rules of hooks are followed:
https://reactjs.org/docs/hooks-faq.html#what-exactly-do-the-lint-rules-enforce
https://www.npmjs.com/package/eslint-plugin-react-hooks

We should add this eslint plugin to @neutrinojs/react.
@edmorley edmorley added this to the v9 milestone Feb 11, 2019
@helfi92 helfi92 self-assigned this Feb 25, 2019
@helfi92 helfi92 mentioned this issue Feb 26, 2019
Merged
@edmorley edmorley mentioned this issue Mar 24, 2019
Merged
edmorley added a commit that referenced this issue Mar 24, 2019
@edmorley
react: Enable eslint-plugin-react-hooks rules (#1335)
9920d0e 
The `eslint-plugin-react-hooks` plugin was added in #1309, however the
rules it provides were not enabled. This enables those rules, using the
settings recommended in the plugin README (which also matches those used
by CRA):
https://github.com/facebook/react/tree/master/packages/eslint-plugin-react-hooks

Fixes #1300.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@helfi92 helfi92

Labels
feature
Milestone
Neutrino 9
Development

No branches or pull requests
2 participants
@edmorley @helfi92