This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Add eslint-plugin-react-hooks to @neutrinojs/react #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliperelman
approved these changes
Feb 28, 2019
|
Hm, I think it should be fine. According to https://reactjs.org/docs/hooks-intro.html#no-breaking-changes, hooks are 100% backwards-compatible. |
edmorley
added a commit
that referenced
this pull request
Mar 24, 2019
The `eslint-plugin-react-hooks` plugin was added in #1309, however the rules it provides were not enabled. This enables those rules, using the settings recommended in the plugin README (which also matches those used by CRA): https://github.com/facebook/react/tree/master/packages/eslint-plugin-react-hooks Fixes #1300.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1300.