This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
tests: Clean up t.throws() and async usage #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The error message can be checked by `t.throws()` itself, so no need for a separate assertion for that afterwards. * We were marking several tests as async that were actually not.
edmorley
added a commit
that referenced
this pull request
Oct 9, 2018
* An error is now shown when using the `links` HTML option without also specifying a custom template, so that users affected by #1049 know what changes they need to make. See: #1129 (comment) * The migration guide now recommends regenerating the lockfiles. * The migration section about supported Node.js versions has been made clearer. See: #1129 (comment) * The `neutrino` bin script error message now mentions `test` being removed, includes `--mode` for the inspect example, and uses the correct URL for the migration guide. * The `minify.image` option deprecation error message no longer refers to `@neutrinojs/image-minify`, since it was removed. I've linked to the issue since it gives more background as to why compile-time minification is not recommended. * The `hotEntries` option deprecation check now always occurs, and not only when `options.hot` is enabled. A test has also been added. * Cleans up a few more `t.throws()` usages (missed in #1159).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
t.throws()itself, so no need for a separate assertion for that afterwards.