This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Improvements to the Neutrino 9 migration UX #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliperelman
approved these changes
Oct 9, 2018
docs/migration-guide.md
Outdated
| @@ -39,12 +39,15 @@ neutrino --inspect --mode production > v9.config | |||
| git diff --no-index v8.config v9.config | |||
| ``` | |||
|
|
|||
| Please [file an issue](https://github.com/neutrinojs/neutrino/issues) if any issue arises from upgrade | |||
| that may not be outlined here. | |||
| **We strongly recommend that any Yarn/NPM lockfiles (eg `yarn.lock` or `package-lock.json`) are | |||
packages/html-template/index.js
Outdated
| throw new Error( | ||
| 'The default Neutrino HTML template no longer supports the "links" option. ' + | ||
| 'To set a favicon use the "favicon" option instead. For stylesheets either ' + | ||
| 'import the equivalent NPM package from JS, or if using a CDN is preferred, ' + |
* An error is now shown when using the `links` HTML option without also specifying a custom template, so that users affected by #1049 know what changes they need to make. See: #1129 (comment) * The migration guide now recommends regenerating the lockfiles. * The migration section about supported Node.js versions has been made clearer. See: #1129 (comment) * The `neutrino` bin script error message now mentions `test` being removed, includes `--mode` for the inspect example, and uses the correct URL for the migration guide. * The `minify.image` option deprecation error message no longer refers to `@neutrinojs/image-minify`, since it was removed. I've linked to the issue since it gives more background as to why compile-time minification is not recommended. * The `hotEntries` option deprecation check now always occurs, and not only when `options.hot` is enabled. A test has also been added. * Cleans up a few more `t.throws()` usages (missed in #1159).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linksHTML option without also specifying a custom template, so that users affected by html-template: Replace html-webpack-template with our own template #1049 know what changes they need to make. See:Neutrino 9 beta/release candidate feedback #1129 (comment)
Neutrino 9 beta/release candidate feedback #1129 (comment)
neutrinobin script error message now mentionstestbeing removed, includes--modefor the inspect example, and uses the correct URL for the migration guide.minify.imageoption deprecation error message no longer refers to@neutrinojs/image-minify, since it was removed. I've linked to the issue since it gives more background as to why compile-time minification is not recommended.hotEntriesoption deprecation check now always occurs, and not only whenoptions.hotis enabled. A test has also been added.