Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Update dependency eslint-loader to v3 #1455

Merged
merged 3 commits into from
Sep 2, 2019
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 25, 2019

This PR contains the following updates:

Package Type Update Change
eslint-loader dependencies major ^2.2.1 -> ^3.0.0

Release Notes

webpack-contrib/eslint-loader

v3.0.0

Compare Source


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@edmorley
Copy link
Member

We should be able to take advantage of webpack-contrib/eslint-loader/pull/285 to simplify our log formatter handling slightly :-)

@edmorley edmorley added this to the Neutrino 9 milestone Aug 27, 2019
@renovate renovate bot force-pushed the renovate/eslint-loader-3.x branch from 8b03b01 to 537db9f Compare September 1, 2019 15:57
Since eslint-loader now natively supports being passed a `formatter` that
is the name of an in-built ESLint formatter (rather than only supporting
a full filepath to that formatter), so @neutrinojs/eslint does not need
to handle this case itself.
@renovate
Copy link
Contributor Author

renovate bot commented Sep 1, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@edmorley
Copy link
Member

edmorley commented Sep 1, 2019

I've added an additional commit which removes @neutrinojs/eslint's custom handling of named formatters - since eslint-loader now natively supports being passed a formatter that
is the name of an in-built ESLint formatter (rather than only supporting a full file-path to that formatter), so the preset does not need to handle this case itself.

@edmorley edmorley self-assigned this Sep 1, 2019
Due to the landings of #1447 and #1453 racing with each other.
@edmorley edmorley merged commit 706da6e into master Sep 2, 2019
@edmorley edmorley deleted the renovate/eslint-loader-3.x branch September 2, 2019 06:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

2 participants