This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Update eslint-config-airbnb and eslint-config-airbnb-base #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Combines #1443 and #1444 (since they are dependant on each other) * Adds the new AirBnB hooks preset to `@neutrinojs/airbnb` * Removes the React `version` option from `@neutrinojs/airbnb` since it's now configured within `eslint-config-airbnb` * Switches other React `version` usages to the new `'detect'` mode * Overrides AirBnB's configuration for `react/state-in-constructor` since `@neutrinojs/react` supports class properties, so using the `always` mode is unnecessary. Closes #1443 and closes #1444.
1 task
|
@neutrinojs/core-contributors any comments before I merge? :-) |
|
Looks good from here, @edmorley |
edmorley
pushed a commit
that referenced
this pull request
Sep 2, 2019
* Update dependency eslint-loader to v3 * eslint: Remove custom handling of named formatters Since eslint-loader now natively supports being passed a `formatter` that is the name of an in-built ESLint formatter (rather than only supporting a full filepath to that formatter), so @neutrinojs/eslint does not need to handle this case itself. * airbnb: Fix inconsistent eslint-plugin-react-hooks version Due to the landings of #1447 and #1453 racing with each other.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@neutrinojs/airbnbversionoption from@neutrinojs/airbnbsince it's now configured withineslint-config-airbnbversionusages to the new'detect'modereact/state-in-constructorsince@neutrinojs/reactsupports class properties, so using thealwaysmode is unnecessary.Closes #1443 and closes #1444.