Add option to get package.json content #534

helfi92 · 2017-12-04T17:36:01Z

References #516.

eliperelman

YAAAAAAAAAAAAAAAAS!

One change, but YAAAAAAAAAS!

eliperelman · 2017-12-04T17:45:19Z

packages/neutrino/src/api.js

@@ -49,6 +50,8 @@ class Api {
      });
    });

+    options.packageJson = require(path.join(options.root, 'package.json')); // eslint-disable-line global-require


The section you removed from the node preset is essentially what we need here. We need to try to require the file, but not blow up if it's not there. Maybe we should consider setting this to an empty object? Not sure...

Meh, we can leave it undefined.

eliperelman · 2017-12-04T17:48:16Z

Any thoughts on the option name? While packageJson works, it seems kinda awkward. cc: @edmorley

helfi92 · 2017-12-04T18:00:38Z

I hear you, I think it looks awkward too. pkgJson is slightly better. I don't like package just because it's hard to know what kind of package it is by simply looking at the name.

eliperelman · 2017-12-04T19:41:31Z

I'm just annoyed at the Json part. I think I prefer package over packageJson, but neither make me happy. Maybe there's another word we can use?

eliperelman · 2017-12-04T19:43:17Z

Meh, if anything we should probably roll with packageJson since it's the most descriptive and relevant. Let's see what @edmorley thinks.

edmorley · 2017-12-04T19:53:08Z

packageMetadata, projectMetadata, ...?

I can't think of a great name either really! :-)

helfi92 · 2017-12-04T19:55:50Z

OK, reverting back to packageJson 🤢 hehe

eliperelman

Just a couple little changes.

eliperelman · 2017-12-05T07:50:58Z

packages/neutrino/src/api.js

+    try {
+      options.packageJson = require(path.join(options.root, 'package.json')); // eslint-disable-line global-require
+    } catch (err) {
+      options.packageJson = undefined;


Let's use null here instead.

eliperelman · 2017-12-05T07:51:17Z

packages/neutrino/src/api.js

@@ -2,6 +2,7 @@ const Config = require('webpack-chain');
 const merge = require('deepmerge');
 const Future = require('fluture');
 const mitt = require('mitt');
+const path = require('path');


Destructure out join.

eliperelman · 2017-12-05T07:51:26Z

packages/library/index.js

@@ -64,7 +64,8 @@ module.exports = (neutrino, opts = {}) => {
  }

  try {
-    const pkg = require(join(neutrino.options.root, 'package.json')); // eslint-disable-line global-require
+    const pkg = neutrino.options.packageJson;
+


Remove extra blank line.

* Remove extra blank line * Destructure out join * Use null instead of undefined for options.packageJson

eliperelman · 2017-12-05T15:19:16Z

Also need to add blurbs to the docs about this option.

eliperelman · 2017-12-05T15:19:24Z

We can do that in another bug if you like.

helfi92 · 2017-12-05T15:20:44Z

Yes, will open up a different PR for this. Thanks for the reminder.

* Add packageJson option to get package.json * Wrap require statement with try catch and rename packageJson * Revert pkgJson to packageJson * Nits * Remove extra blank line * Destructure out join * Use null instead of undefined for options.packageJson

* Move imagemin to image-minify Move minify to babel-minify Make minify an aggregate * Readme fixes, plugin const * Allow excluding presets by passing false in `minify` * WS * Never pass true, {} instead * Coerce true from web. * Fix short circuit * Removing log. * Sync docs/ and packages/ and other docs fixes (#528) * Docs: Sync the READMEs in docs/ and packages/ * Docs: Remove duplicate "zero upfront configuration" reference Since it appears in both the "extends from" and the main features list. * Docs: Sync the web features list with presets that extend from it * Docs: Fix description for react-components * Update outstanding changes to docs and add more detailed comments (#531) * Migrate clean options from v7 branch to master to allow all options for clean middleware (#530) * Remove json from being in options.extensions, update docs on extensions accordingly (#533) * Revert broken changes in image minification middleware's testing determination, do not join. (#536) * Revert broken changes, do not join. * Filter tests * Filter boolean * Udate CHANGELOG.md (#535) * Merge test babel config in root config to deal with JSX pragma plugin precedence (#537) * Move imagemin to image-minify Move minify to babel-minify Make minify an aggregate * Allow excluding presets by passing false in `minify` * Coerce true from web. * Improve help/incorrect usage output of CLI (#514) * Add option to get package.json content (#534) * Add packageJson option to get package.json * Wrap require statement with try catch and rename packageJson * Revert pkgJson to packageJson * Nits * Remove extra blank line * Destructure out join * Use null instead of undefined for options.packageJson * Use extensions in outstanding package (#532) * Update tests * Fix doc paths. * Merge options, minify by default when calling directly. * No style-minify yet

Add packageJson option to get package.json

4234907

helfi92 self-assigned this Dec 4, 2017

helfi92 requested a review from eliperelman December 4, 2017 17:36

eliperelman suggested changes Dec 4, 2017

View reviewed changes

Wrap require statement with try catch and rename packageJson

36022e7

helfi92 requested a review from eliperelman December 4, 2017 18:11

Revert pkgJson to packageJson

f893771

eliperelman suggested changes Dec 5, 2017

View reviewed changes

Nits

4d6d7b5

* Remove extra blank line * Destructure out join * Use null instead of undefined for options.packageJson

helfi92 requested a review from eliperelman December 5, 2017 14:21

eliperelman approved these changes Dec 5, 2017

View reviewed changes

eliperelman added the feature label Dec 5, 2017

helfi92 merged commit a653992 into neutrinojs:master Dec 5, 2017

eliperelman mentioned this pull request Dec 5, 2017

Extend neutrino options with project package.json #516

Closed

eliperelman mentioned this pull request Dec 6, 2017

Remove reliance on babel environments, make babel options merging consistent #548

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add option to get package.json content #534

Add option to get package.json content #534

helfi92 commented Dec 4, 2017 •

edited

Loading

eliperelman left a comment

eliperelman Dec 4, 2017

eliperelman Dec 4, 2017

eliperelman commented Dec 4, 2017

helfi92 commented Dec 4, 2017

eliperelman commented Dec 4, 2017

eliperelman commented Dec 4, 2017

edmorley commented Dec 4, 2017

helfi92 commented Dec 4, 2017

eliperelman left a comment

eliperelman Dec 5, 2017

eliperelman Dec 5, 2017

eliperelman Dec 5, 2017

eliperelman commented Dec 5, 2017

eliperelman commented Dec 5, 2017

helfi92 commented Dec 5, 2017

Add option to get package.json content #534

Add option to get package.json content #534

Conversation

helfi92 commented Dec 4, 2017 • edited Loading

eliperelman left a comment

Choose a reason for hiding this comment

eliperelman Dec 4, 2017

Choose a reason for hiding this comment

eliperelman Dec 4, 2017

Choose a reason for hiding this comment

eliperelman commented Dec 4, 2017

helfi92 commented Dec 4, 2017

eliperelman commented Dec 4, 2017

eliperelman commented Dec 4, 2017

edmorley commented Dec 4, 2017

helfi92 commented Dec 4, 2017

eliperelman left a comment

Choose a reason for hiding this comment

eliperelman Dec 5, 2017

Choose a reason for hiding this comment

eliperelman Dec 5, 2017

Choose a reason for hiding this comment

eliperelman Dec 5, 2017

Choose a reason for hiding this comment

eliperelman commented Dec 5, 2017

eliperelman commented Dec 5, 2017

helfi92 commented Dec 5, 2017

helfi92 commented Dec 4, 2017 •

edited

Loading