Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Update CHANGELOG.md #535

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Update CHANGELOG.md #535

merged 1 commit into from
Dec 5, 2017

Conversation

rodmoreno
Copy link
Contributor

No description provided.

@rodmoreno
Copy link
Contributor Author

What do you think about adding the following script to the package.json?

"prerelease": "yarn version",

@eliperelman
Copy link
Member

@rodmoreno I think that is probably the right move. I don't think auto-changelog is automatically updating it when we release via lerna. @cookpete could you confirm it should work this way, and whether we have the right command in place in our package.json?

@cookpete
Copy link
Contributor

cookpete commented Dec 5, 2017

Updating the changelog manually like this shouldn't be necessary if things are set up correctly. I don't know much about lerna but if there is an npm version equivalent that runs every time you create a version commit, you should be able to add yarn changelog and never worry about doing it manually.

Also, since #524 the changelog will be very different to this, with many more correctly parsed merge commits.

@eliperelman
Copy link
Member

I did some digging into lerna, and it looks like they are supposed to run the preversion, version, and postversion scripts when using the lerna publish command. Unfortunately, looking at our last tag, it appears to not have worked, as no CHANGELOG was generated:

b5f9d68

@cookpete maybe since we used the --package flag, it's possible that nothing was updated since this could have happened prior to the tag actually being created?

@cookpete
Copy link
Contributor

cookpete commented Dec 5, 2017

Yep it looks like there is some work to be done for auto-changelog to support lerna properly. I'll look into it.

@eliperelman
Copy link
Member

Wow, thanks! Let me know if there's anything you need support-wise from me.

@cookpete
Copy link
Contributor

cookpete commented Dec 5, 2017

It looks like Lerna doesn't have an npm version equivalent that we can hook in to. There is a small discussion here but no real solution yet.

You can add "version": "auto-changelog -p && git add CHANGELOG.md" to each package, which works, but will generate the same CHANGELOG.md inside each package directory, not in the root folder.

Annoyingly, Lerna has built in support for generating a conventional-changelog if you are using conventional commits, but no way of hooking in your own scripts to that process instead.

@eliperelman
Copy link
Member

Hmm ok, that's unfortunate. We will keep an eye on this then.

@eliperelman eliperelman merged commit d78de34 into neutrinojs:master Dec 5, 2017
@cookpete
Copy link
Contributor

cookpete commented Dec 5, 2017

Note that the changelog still needs updating with the latest auto-changelog update since #524. The current changelog still contains unparsed merges.

timkelty pushed a commit that referenced this pull request Dec 5, 2017
@eliperelman
Copy link
Member

@cookpete running the changelog script in master just now produces the following changes:

master...eliperelman:changelog-discrepancies

Which removed the v7.3.3 and v7.4.0 tags.

@cookpete
Copy link
Contributor

cookpete commented Dec 5, 2017

Looks good but yeah the missing versions is a bit weird. Do you have the latest commits/tags pulled down locally? The tags need to exist on the machine that is generating the changelog.

eliperelman pushed a commit that referenced this pull request Dec 5, 2017
* Move imagemin to image-minify
Move minify to babel-minify
Make minify an aggregate

* Readme fixes, plugin const

* Allow excluding presets by passing false in `minify`

* WS

* Never pass true, {} instead

* Coerce true from web.

* Fix short circuit

* Removing log.

* Sync docs/ and packages/ and other docs fixes (#528)

* Docs: Sync the READMEs in docs/ and packages/

* Docs: Remove duplicate "zero upfront configuration" reference

Since it appears in both the "extends from" and the main features
list.

* Docs: Sync the web features list with presets that extend from it

* Docs: Fix description for react-components

* Update outstanding changes to docs and add more detailed comments (#531)

* Migrate clean options from v7 branch to master to allow all options for clean middleware (#530)

* Remove json from being in options.extensions, update docs on extensions accordingly (#533)

* Revert broken changes in image minification middleware's testing determination, do not join. (#536)

* Revert broken changes, do not join.

* Filter tests

* Filter boolean

* Udate CHANGELOG.md (#535)

* Merge test babel config in root config to deal with JSX pragma plugin precedence (#537)

* Move imagemin to image-minify
Move minify to babel-minify
Make minify an aggregate

* Allow excluding presets by passing false in `minify`

* Coerce true from web.

* Improve help/incorrect usage output of CLI (#514)

* Add option to get package.json content (#534)

* Add packageJson option to get package.json

* Wrap require statement with try catch and rename packageJson

* Revert pkgJson to packageJson

* Nits

* Remove extra blank line
* Destructure out join
* Use null instead of undefined for options.packageJson

* Use extensions in outstanding package (#532)

* Update tests

* Fix doc paths.

* Merge options, minify by default when calling directly.

* No style-minify yet
@eliperelman
Copy link
Member

eliperelman commented Dec 5, 2017

@cookpete yeah, I checked that prior, which is strange:

screenshot tags

@edmorley edmorley changed the title Udate CHANGELOG.md Update CHANGELOG.md Dec 5, 2017
@cookpete
Copy link
Contributor

cookpete commented Dec 5, 2017

@eliperelman Did you have the right branch checked out when you ran it, ie the branch with v7.4.0 in? I just checked out and ran auto-changelog (on branch release/v7) and it seemed fine.

@eliperelman
Copy link
Member

I was in master when I ran it...

@eliperelman
Copy link
Member

But yeah, it does work correctly when in the release branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

3 participants