-
Notifications
You must be signed in to change notification settings - Fork 214
Conversation
What do you think about adding the following script to the package.json? "prerelease": "yarn version", |
@rodmoreno I think that is probably the right move. I don't think auto-changelog is automatically updating it when we release via lerna. @cookpete could you confirm it should work this way, and whether we have the right command in place in our package.json? |
Updating the changelog manually like this shouldn't be necessary if things are set up correctly. I don't know much about lerna but if there is an Also, since #524 the changelog will be very different to this, with many more correctly parsed merge commits. |
I did some digging into lerna, and it looks like they are supposed to run the @cookpete maybe since we used the |
Yep it looks like there is some work to be done for |
Wow, thanks! Let me know if there's anything you need support-wise from me. |
It looks like Lerna doesn't have an You can add Annoyingly, Lerna has built in support for generating a |
Hmm ok, that's unfortunate. We will keep an eye on this then. |
Note that the changelog still needs updating with the latest |
@cookpete running the changelog script in master just now produces the following changes: master...eliperelman:changelog-discrepancies Which removed the v7.3.3 and v7.4.0 tags. |
Looks good but yeah the missing versions is a bit weird. Do you have the latest commits/tags pulled down locally? The tags need to exist on the machine that is generating the changelog. |
* Move imagemin to image-minify Move minify to babel-minify Make minify an aggregate * Readme fixes, plugin const * Allow excluding presets by passing false in `minify` * WS * Never pass true, {} instead * Coerce true from web. * Fix short circuit * Removing log. * Sync docs/ and packages/ and other docs fixes (#528) * Docs: Sync the READMEs in docs/ and packages/ * Docs: Remove duplicate "zero upfront configuration" reference Since it appears in both the "extends from" and the main features list. * Docs: Sync the web features list with presets that extend from it * Docs: Fix description for react-components * Update outstanding changes to docs and add more detailed comments (#531) * Migrate clean options from v7 branch to master to allow all options for clean middleware (#530) * Remove json from being in options.extensions, update docs on extensions accordingly (#533) * Revert broken changes in image minification middleware's testing determination, do not join. (#536) * Revert broken changes, do not join. * Filter tests * Filter boolean * Udate CHANGELOG.md (#535) * Merge test babel config in root config to deal with JSX pragma plugin precedence (#537) * Move imagemin to image-minify Move minify to babel-minify Make minify an aggregate * Allow excluding presets by passing false in `minify` * Coerce true from web. * Improve help/incorrect usage output of CLI (#514) * Add option to get package.json content (#534) * Add packageJson option to get package.json * Wrap require statement with try catch and rename packageJson * Revert pkgJson to packageJson * Nits * Remove extra blank line * Destructure out join * Use null instead of undefined for options.packageJson * Use extensions in outstanding package (#532) * Update tests * Fix doc paths. * Merge options, minify by default when calling directly. * No style-minify yet
@cookpete yeah, I checked that prior, which is strange: |
@eliperelman Did you have the right branch checked out when you ran it, ie the branch with |
I was in master when I ran it... |
But yeah, it does work correctly when in the release branch. |
No description provided.