Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Cleanup monorepo linting configuration #758

Merged
merged 4 commits into from
Mar 23, 2018
Merged

Cleanup monorepo linting configuration #758

merged 4 commits into from
Mar 23, 2018

Commits on Mar 22, 2018

  1. Remove React presets/rules from monorepo lint config

    Since we don't currently lint any React files, and if we start doing so
    in the future we should use the airbnb preset instead of airbnb-base.
    edmorley committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    11ab7ea View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary monorepo linting rule overrides

    These rules are now either set via the AirBnb or prettier presets,
    or else are no longer required. Fewer overrides makes it easier
    to reason about the actual differences between AirBnB/prettier and
    the linting config used for this monorepo.
    
    The only code fix required was making `_logo()` be a static method
    in the create-project init command, to fix:
    https://eslint.org/docs/rules/class-methods-use-this
    edmorley committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    bae0170 View commit details
    Browse the repository at this point in the history
  3. Make monorepo linting file includes less fragile

    Switches from opt-in to opt-out to avoid accidentally omitting new
    directories or non-JS file types. The list of files scanned is the
    same before/after (confirmed using `yarn lint --debug`).
    edmorley committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    acc4d72 View commit details
    Browse the repository at this point in the history
  4. Add eslint to monorepo root devDependencies

    This prevents warnings during yarn install of the monorepo:
    ```
    warning " > eslint-config-prettier@2.9.0" has unmet peer dependency "eslint@>=3.14.1".
    ```
    edmorley committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    78900e4 View commit details
    Browse the repository at this point in the history