Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of lead-related contamination properties #184

Closed
7 tasks done
prisma34 opened this issue Jul 18, 2024 · 1 comment
Closed
7 tasks done

Implementation of lead-related contamination properties #184

prisma34 opened this issue Jul 18, 2024 · 1 comment
Assignees
@prisma34
Labels
enhancement New feature or request
Milestone
Release of v3.0.0

Comments

@prisma34
Copy link

prisma34 commented Jul 18, 2024 •
edited
Loading

Add the correlations related to contaminating metallic compounds in pure lead, according to the sub-package defined in issue #183.
The correlations are:

  • Polonium vapour pressure by Abakumov, 1994a.

  • Polonium Henry constant by Ohno, 2006.

  • Polonium activity coefficient by Li, 1998.

  • Iodine vapour pressure by Konings, 1996.

  • Iodine vapour pressure by Knacke, 1991.

  • Caesium Henry constant by Yamshchikov, 2001.

  • Caesium vapour pressure by Yamshchikov, 2001.
@prisma34 prisma34 mentioned this issue Jul 18, 2024
Open
4 tasks
@lelaus lelaus changed the title Implementation of lead related properties Implementation of lead-related contamination properties Jul 18, 2024
@lelaus lelaus added the enhancement New feature or request label Jul 18, 2024
@lelaus lelaus added this to the Release of v3.0.0 milestone Jul 18, 2024
prisma34 pushed a commit that referenced this issue Jul 19, 2024
[184_lead_contamination], issue #184, Implementation of Polonium vapo…
2d7255e 
…ur pressure by Abakumov, 1994a.
prisma34 pushed a commit that referenced this issue Jul 19, 2024
[184_lead_contamination], issue #184, Implementation of Polonium Henr…
1206a5b 
…y constant by Ohno, 2006.
prisma34 pushed a commit that referenced this issue Jul 19, 2024
[184_lead_contamination], issue #184, Implementation of Polonium acti…
3fc5141 
…vity coefficient by Li, 1998.
prisma34 pushed a commit that referenced this issue Jul 19, 2024
[184_lead_contamination], issue #184, Implementation of Iodine vapour…
078d5fa 
… pressure by Konings, 1996.
prisma34 pushed a commit that referenced this issue Jul 19, 2024
[184_lead_contamination], issue #184, Implementation of Iodine vapour…
a7943eb 
… pressure by Knacke, 1991.
prisma34 pushed a commit that referenced this issue Jul 19, 2024
[184_lead_contamination], issue #184, Implementation of Caesium Henry…
5e749c6 
… constant by Yamshchikov, 2001.
prisma34 pushed a commit that referenced this issue Jul 19, 2024
[184_lead_contamination], issue #184, Implementation of Caesium vapou…
86f80ca 
…r pressure by Yamshchikov, 2001.
prisma34 pushed a commit that referenced this issue Jul 22, 2024
[184_lead_contamination], issue #184, Implementation of lead_contamin…
d011b75 
…ation path in __init__.py.
prisma34 pushed a commit that referenced this issue Jul 24, 2024
[184_lead_contamination], issue #184, Changes made on vapour pressure…
4977981 
… by Abakumov (1994a) and activity coefficient of Polonium by Li (1998). Same changes made for the other classes. Removal of Henry constant by Ohno (2006).
prisma34 pushed a commit that referenced this issue Jul 24, 2024
[184_lead_contamination], issue #184, Removal of Polonium activity co…
2849fb9 
…efficient by Abakumov (1974a) for the same reasons as the removal of Henry constant by Ohno (2006).
prisma34 pushed a commit that referenced this issue Jul 25, 2024
[184_lead_contamination], issue #184, Implementation of activity coef…
5e095f2 
…ficient and Henry constant for Polonium. Same work done in prevision for Iodine and Caesium.
prisma34 pushed a commit that referenced this issue Jul 26, 2024
[184_lead_contamination], issue #184, Correction of errors in docstri…
3f4eaad 
…ngs.
prisma34 pushed a commit that referenced this issue Jul 26, 2024
[184_lead_contamination], issue #184, Modifications on docstrings.
311b621
@panDanieleN panDanieleN mentioned this issue Jul 26, 2024
Merged
prisma34 pushed a commit that referenced this issue Jul 26, 2024
[184_lead_contamination], issue #184, Changes from 10** to np.power f…
a8ec760 
…or all the classes of the module. Verification of the good handling of array-like elements.
prisma34 pushed a commit that referenced this issue Jul 26, 2024
[184_lead_contamination], issue #184, All the modifications suggested…
ac2cf84 
… by lelaus have been made.
prisma34 pushed a commit that referenced this issue Jul 26, 2024
[184_lead_contamination], issue #184, Small modifications on correlat…
af513cd 
…ions' syntaxes.
prisma34 pushed a commit that referenced this issue Jul 26, 2024
[184_lead_contamination], issue #184, Small modifications on correlat…
16c5e02 
…ions' syntaxes.
prisma34 pushed a commit that referenced this issue Jul 26, 2024
[184_lead_contamination], issue #184, Modifications related to Caesiu…
8badf5b 
…m properties required in the review have been made.
prisma34 pushed a commit that referenced this issue Jul 26, 2024
[184_lead_contamination], issue #184, Reviewed code according to pyco…
553be78 
…destyle.
prisma34 pushed a commit that referenced this issue Jul 26, 2024
[184_lead_contamination], issue #184, Reviewed code according to pylint.
ae10ae2
prisma34 pushed a commit that referenced this issue Jul 29, 2024
[184_lead_contamination], issue #184, Creation of the abstract classe…
8939eb4 
…s and deriving correlations from it.
prisma34 pushed a commit that referenced this issue Jul 29, 2024
[184_lead_contamination], issue #184, The P_PbI2 and K_PbI2 from knac…
15b14b9 
…ke1991 have been defined as the correlations to use. The path properties.lead_thermochemical_properties.lead_contamination has been implemented in _properties_modules_list in order to not interfere with the tests.
@lelaus
Copy link
Collaborator

lelaus commented Jul 30, 2024

The required properties have been implemented.

No modification yet applied to doc (issue #196).
No modification yet applied to test (issue #189).

@lelaus lelaus closed this as completed Jul 30, 2024
@prisma34 prisma34 mentioned this issue Aug 1, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prisma34 prisma34

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release of v3.0.0
Development

No branches or pull requests
2 participants
@prisma34 @lelaus