Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of pure lead contamination's tests #189

Closed
5 tasks done
prisma34 opened this issue Jul 18, 2024 · 3 comments
Closed
5 tasks done

Implementation of pure lead contamination's tests #189

prisma34 opened this issue Jul 18, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@prisma34
Copy link

prisma34 commented Jul 18, 2024

Implement tests for initialization and boundary values verification for contaminating compounds in pure lead.
It involves the implementation of the LeadContaminationTester class, with:

  • the test_init_fromX method in test_lead_fromX_spanT.
  • the test_min method in test_lbh15_bounds.py.
  • the test_max method in test_lbh15_bounds.py.
  • the test_T_at_min method in test_lbh15_bounds.py.
  • the test_T_at_max method in test_lbh15_bounds.py.

This issue is handled as one of the tasks of issue #188.

@lelaus lelaus added the enhancement New feature or request label Jul 18, 2024
@lelaus lelaus added this to the Release of v3.0.0 milestone Jul 18, 2024
prisma34 pushed a commit that referenced this issue Jul 22, 2024
…ization and boundary values verification for contaminating compounds in pure lead. Also adds the values needed for all metal compounds in properties_bounds.json
prisma34 pushed a commit that referenced this issue Jul 22, 2024
…nch for updating the path of lead_contamination in __init__.py.
prisma34 pushed a commit that referenced this issue Jul 22, 2024
… branch for updating the path of bismuth_contamination in __init__.py.
prisma34 pushed a commit that referenced this issue Jul 22, 2024
…nch for updating the path of lbe_contamination in __init__.py.
prisma34 pushed a commit that referenced this issue Jul 23, 2024
… files path in lead.py, bismuth.py and lbe.py
prisma34 pushed a commit that referenced this issue Aug 12, 2024
…on_tests_in_common for organisation purposes and to help tests to pass.
prisma34 pushed a commit that referenced this issue Aug 27, 2024
6ec7db2 in Actions on the github repository), correction of docstrings.
prisma34 pushed a commit that referenced this issue Aug 28, 2024
…a additional entry of guess_helper method for coherence with the changes made on the issue 191. Implementation in _lbh15.py, lead_properties.py and lead_contamination.py accordingly to this change.
@lelaus
Copy link
Collaborator

lelaus commented Aug 29, 2024

A few properties of contaminants provide a constant value. This disable the possibility to initialize a liquid metal object by providing the value of such properties to the constructor.
In the method _compute_T() this aspect must be managed appropriately. For the time being, a check requiring several computations of the property correlations is implemented to identify whether the correlation provide a constant value. Although correct, this procedure increases the effort of the code, thus reducing its computational efficiency.
To reduce this increase of effort, I'd suggest to add the method is_constant() to the abstract class PropertyInterface, which by default returns False. In each property class whose correlation provide a constant value, such method must be overridden by making it return True. In this way, in _compute_T() the only check to perform is about the value returned by the method is_constant().

prisma34 pushed a commit that referenced this issue Aug 29, 2024
…ant method. Addition of the non injectivity of P_PbCs and K_PbCs.
@prisma34
Copy link
Author

Tasks from the second to the last are handled in issue #188.

@lelaus
Copy link
Collaborator

lelaus commented Aug 29, 2024

The first task of this issue has been managed. Since constant properties are added, the method is_constant() has been implemented in the class PropertyInterface to quickly identify such properties.

No need to change the doc.

Tests for lead contaminant properties have been added.

@lelaus lelaus closed this as completed Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants