188 contamination tests in common #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ization and boundary values verification for contaminating compounds in pure lead. Also adds the values needed for all metal compounds in properties_bounds.json
…tion and boundary values verification for contaminating compounds in pure bismuth.
…tion and boundary values verification for contaminating compounds in LBE.
…nch for updating the path of lead_contamination in __init__.py.
… branch for updating the path of bismuth_contamination in __init__.py.
…nch for updating the path of lbe_contamination in __init__.py.
… files path in lead.py, bismuth.py and lbe.py
…on_tests_in_common for organisation purposes and to help tests to pass.
…operty bounds, impplementation of LeadContaminationTester, BismuthContaminationTester and LBEContaminationTester. Samll modifications of heavy liquid metal contamination modules to fit with the tests. No need of inisialization_helper methods.
…les non related to lead for coherence with the new issue's organisation. Implementation of ContaminationTester in test_lead_fromX_spanT.py. Implementation of a new method in interface, called guess_helper, to help fsolve when the correlation is non injective. Accordingly, modification has been made in _lbh15.py. Implementation in _lbh15.py and in test_lead_fromX_spanT.py to handle the constant correlations, in lead. update of _roots_to_use dictionnary in lead.py.
6ec7db2 in Actions on the github repository), correction of docstrings.
…_bismuth_fromX_spanT of BismuthContaminationTester method. New implementations in _lbh15.py and test_bismuth_fromX_spanT to handle the case of constant correlations. Implementation of guess_helper for cp in bismuth_properties.py. guess_helper method introduced also in interface.py.
…s_helper in cp_sobolev2011 and cp_gurvich1991 accordingly to the changes made in _lbh15.py, as it was made in branch 189.
…minationTester in test_lbe_fromX_spanT. Implementation of guess_helper method in interface.py. Implementation of guess_helper method for non injective correlation in lbe_properties.py, bismuth_properties.py, lead_properties.py and lbe_contamination.py. Implementation of initialization_helper method in lbe_contamination.py to help pass the test. Implementation in _lbh15.py of method to handle constant correlation and non injective correlation.
…a additional entry of guess_helper method for coherence with the changes made on the issue 191. Implementation in _lbh15.py, lead_properties.py and lead_contamination.py accordingly to this change.
…alue as an additional entry of guess_helper method for coherence with the changes made on the issue 191. Implementation in _lbh15.py, lead_properties.py and bismuth_properties.py accordingly to this change.
…automatic tests
…lues file following the local update of numpy according to the version used in github platform
…ant method. Addition of the non injectivity of P_PbCs and K_PbCs.
189 contamination tests
…amination_tests.
…stant() method in bismuth_contamination.py. Adaptation of test_bismuth_fromX_spanT.py accordingly.
…_bismuth 190 contamination tests bismuth
…onstant() method adaptations. Modification of load_prop() in test_lbe_fromX_spanT.py.
…orks in local. It has been a little bit cleaned to test it again remotely.
…nt validity ranges between lead and LBE
…nce data according to what done when handling issue 188
…_lbe 191 contamination tests lbe
|
Tests related to all heavy liquid metal contaminant properties have been added. No need to change the doc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge of the tests to complete the fifth task of issue #183 .