add instrumentation for HTTPX #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everybody Else Is Doing It, So Why Can't We?
reused template fix
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
restrict httpx testing to Ruby 2.7+
- third argument to `prepend_instrument` is unnecessary
- finish testing error handling
- error responses and http responses aren't interchangeable, so
rework the response wrapper accordingly
- error response objects have a great `#to_s` defined, so let's
just use it
kaylareopelle
previously approved these changes
Oct 20, 2023
kaylareopelle
approved these changes
Oct 20, 2023
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds instrumentation for HTTPX
resolves: n/a (Hacktoberfest contribution)