Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add instrumentation for HTTPX #2278

Merged
merged 5 commits into from
Oct 20, 2023
Merged

add instrumentation for HTTPX #2278

merged 5 commits into from
Oct 20, 2023

Commits on Oct 20, 2023

  1. add instrumentation for HTTPX 

    Everybody Else Is Doing It, So Why Can't We?
    @fallwith
    fallwith committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    18fa11d View commit details
    Browse the repository at this point in the history

  2. ethon -> httpx 

    reused template fix
    @fallwith
    fallwith committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    16ac00b View commit details
    Browse the repository at this point in the history

  3. httpx requires Ruby 2.7+ 

    restrict httpx testing to Ruby 2.7+
    @fallwith
    fallwith committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    ec8fb9b View commit details
    Browse the repository at this point in the history

  4. address HTTPX PR feedback 

    - third argument to `prepend_instrument` is unnecessary
- finish testing error handling
  - error responses and http responses aren't interchangeable, so
    rework the response wrapper accordingly
  - error response objects have a great `#to_s` defined, so let's
    just use it
    @fallwith
    fallwith committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    ee243b9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'dev' into httpx

    @fallwith
    fallwith committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    4d1ce24 View commit details
    Browse the repository at this point in the history