Merge pull request #1143 from nextcloud-libraries/feat/file-list-acti…

…on-no-icon
nextcloud-libraries · Dec 12, 2024 · 35ae28e · 35ae28e
2 parents 52dd3c8 + a2c5284
commit 35ae28e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/__tests__/fileListAction.spec.ts b/__tests__/fileListAction.spec.ts
@@ -103,6 +103,7 @@ describe('Invalid FileListAction creation', () => {
 	test('Invalid iconSvgInline', () => {
 		expect(() => new FileListAction({
 			id: 'test',
+			iconSvgInline: null,
 			displayName: () => 'Test',
 			order: 0,
 			exec: async () => {},

diff --git a/lib/fileListAction.ts b/lib/fileListAction.ts
@@ -16,7 +16,7 @@ interface FileListActionData {
 	displayName: (view: View) => string
 
 	/** Raw svg string */
-	iconSvgInline: (view: View) => string
+	iconSvgInline?: (view: View) => string
 
 	/** Sort order */
 	order: number
@@ -82,7 +82,7 @@ export class FileListAction {
 			throw new Error('Invalid displayName function')
 		}
 
-		if (!action.iconSvgInline || typeof action.iconSvgInline !== 'function') {
+		if ('iconSvgInline' in action && typeof action.iconSvgInline !== 'function') {
 			throw new Error('Invalid iconSvgInline function')
 		}