Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow omitting icon for file list actions #1143

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Dec 11, 2024

Requested in nextcloud/server#49171

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added enhancement New feature or request 3. to review labels Dec 11, 2024
@Pytal Pytal requested review from artonge and skjnldsv December 11, 2024 23:44
@Pytal Pytal self-assigned this Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Bundle Report

Changes will increase total bundle size by 8 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@nextcloud/files-esm 122.85kB 4 bytes (0.0%) ⬆️
@nextcloud/files-cjs 124.53kB 4 bytes (0.0%) ⬆️

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.62%. Comparing base (af6640e) to head (a2c5284).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1143   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files          23       23           
  Lines         633      633           
  Branches      166      166           
=======================================
  Hits          580      580           
  Misses         46       46           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pytal Pytal changed the title feat: Allow omitting icon for file list action feat: Allow omitting icon for file list actions Dec 11, 2024
@skjnldsv skjnldsv mentioned this pull request Dec 12, 2024
@skjnldsv skjnldsv merged commit 35ae28e into main Dec 12, 2024
18 checks passed
@skjnldsv skjnldsv deleted the feat/file-list-action-no-icon branch December 12, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants