fix(sorting): also check attributes

[skjnldsv]

Needed for nextcloud/server#49140
Because the Trashbin view use a custom attribute key to sort https://github.com/nextcloud/server/blob/aac5859444a54e9774b794ad4b29486bbb384ea7/apps/files_trashbin/src/files_views/trashbinView.ts#L26

[susnux]

makes is clearer, otherwise this is also evaluated if the first value is just falsy like an empty string or the number 0.

Suggested change

	...(sortingOptions.sortingMode !== FilesSortingMode.Name ? [(v: INode) => v[sortingOptions.sortingMode] || v.attributes[sortingOptions.sortingMode]] : []),
	...(sortingOptions.sortingMode !== FilesSortingMode.Name ? [(v: INode) => v[sortingOptions.sortingMode] ?? v.attributes[sortingOptions.sortingMode]] : []),

[skjnldsv]

makes is clearer, otherwise this is also evaluated if the first value is just falsy like an empty string or the number 0.

Wouldn't that be better then ?
We don't really want to sort my an empty string or a 0 🤔

[susnux]

Currently it should not make a difference, due to the top level things we have defined. But it could.
E.g. if you have order of value 0 you want to sort by it.

In general if there is a value for that key it should be sorted by it, only if there is no such key on the node it should sort by the key on the node's attributes, no?

[skjnldsv]

Yes, basically :)
Let me create a followup 👍