-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EmptyContent Reactivity #3090
Conversation
With nc/vue master from yesterday evening (before #3082 was merged), my example from the Tasks app works as it should. The second NcEmptyContent correctly shows up. |
Hmm. @raimund-schluessler Would you mind testing nextcloud/forms#1308 in your setup? 🙈 It is about the Empty-Contents, that are visible on the App-root |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This drops the text check for title :/
Turning it into a prop makes it a breaking change for v6, but brings back validation? |
2d66dea
to
6d85dd0
Compare
Seems more fitting than a slot yes! 👍 |
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
6d85dd0
to
9442870
Compare
Was brought over from https://github.com/nextcloud/nextcloud-vue/blob/8d4c1e5a099bc4d1a7f2d718af0dd89aa1a437eb/src/components/NcButton/NcButton.vue#L322-L325 but that actually would've needed https://github.com/nextcloud/nextcloud-vue/blob/8d4c1e5a099bc4d1a7f2d718af0dd89aa1a437eb/src/components/NcButton/NcButton.vue#L394-L397 as well |
So - this fixes Reactivity for me.
186104852-f83290cf-5ca7-4754-848a-86d62e503ded.mp4
186104885-81e2b846-7d93-40c1-9e51-a0a041aaf99f.mp4
(With this code: https://github.com/nextcloud/forms/pull/1308/files)
@Pytal can you remember, why you introduced that reactivity stuff in #2867 ? Any place, where i can/need to test it?
@raimund-schluessler As you mentioned https://github.com/nextcloud/tasks/blob/0611f1b897c4681035b7e6541247dd4dcc9cea44/src/components/TaskCreateDialog.vue#L77-L85 - Does this work for you on current master? Do you see similar issues as me above (Not seeing the description on second EmptyContent)?