Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumb: add exact prop and fix style #3654

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Breadcrumb: add exact prop and fix style #3654

merged 3 commits into from
Jan 13, 2023

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Jan 13, 2023 •
edited
Loading

  • Add exact prop for vue router
  • Fix styling
Before After
Capture d’écran_2023-01-13_16-31-35 Capture d’écran_2023-01-13_16-31-41

@skjnldsv
feat(Breadcrumb): add exact prop
d5a9ec2 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
fix(Breadcrumb): fix min width
a86b8bd 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working enhancement New feature or request 3. to review Waiting for reviews feature: breadcrumbs Related to the breadcrumbs components labels Jan 13, 2023
@skjnldsv skjnldsv added this to the 7.4.1 milestone Jan 13, 2023
@skjnldsv skjnldsv self-assigned this Jan 13, 2023
@skjnldsv skjnldsv requested review from a team, artonge, Pytal and szaimen and removed request for a team January 13, 2023 15:33
raimund-schluessler
raimund-schluessler approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, besides the wrong description of the exact prop and the two lint warnings.

@raimund-schluessler
Copy link
Contributor

Is this component now used somewhere?

@skjnldsv
Copy link
Contributor Author

Is this component now used somewhere?

Files to vue is in progress 😉
But let me edit this PR slightly, I see click is not propagated from the link. We should v-bind and v-on attributes and listeners

@skjnldsv
feat(Breadcrumb): bind attrs and listeners to the link
64dd165 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Contributor Author

image

szaimen
szaimen approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@skjnldsv skjnldsv merged commit 3c1b851 into master Jan 13, 2023
@skjnldsv skjnldsv deleted the feat/bread branch January 13, 2023 22:00
@skjnldsv skjnldsv mentioned this pull request Jan 18, 2023
Merged
@skjnldsv skjnldsv modified the milestones: 7.4.1, 7.5.0 Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@Pytal Pytal Pytal approved these changes

@szaimen szaimen szaimen approved these changes

@artonge artonge Awaiting requested review from artonge artonge was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working enhancement New feature or request feature: breadcrumbs Related to the breadcrumbs components
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @raimund-schluessler @Pytal @szaimen