Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v7.5.0 #3663

Merged
merged 1 commit into from
Jan 20, 2023
Merged

v7.5.0 #3663

merged 1 commit into from
Jan 20, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Jan 18, 2023 •
edited
Loading

v7.5.0 (2023-01-19)

Full Changelog

🚀 Enhancements

@Pytal Pytal added the 3. to review Waiting for reviews label Jan 18, 2023
@Pytal Pytal self-assigned this Jan 18, 2023
@skjnldsv skjnldsv added this to the 7.5.0 milestone Jan 18, 2023
@skjnldsv
Copy link
Contributor

Please put the changelog in the first post

@raimund-schluessler
Copy link
Contributor

Can we rebase so we get #3665 in as well?

@PVince81
Copy link
Contributor

@raimund-schluessler if urgent, can you do this yourself and update the changelog commit + top post ?

@skjnldsv
Copy link
Contributor

It should not be in the changelog as it's documentation.
Changelog = library related changes only :)

@skjnldsv
Copy link
Contributor

Btw there is a mistake in the changelog, it seems I opened a duplicate PR with

#3654 got reviewed and merged, so github assumed #3653 was too since the commit was the same.
We can remove #3653 from the changelog :)

skjnldsv
skjnldsv previously requested changes Jan 19, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@raimund-schluessler
Copy link
Contributor

It should not be in the changelog as it's documentation.

Changelog = library related changes only :)

Nevermind, I thought it's a bugfix. If it's only documentation, it doesn't need to be in the release.

PVince81
PVince81 approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 after the adjustments

@Pytal
v7.5.0
6dc72b9 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal requested a review from skjnldsv January 19, 2023 17:19
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 20, 2023
@Pytal Pytal merged commit c6cf393 into master Jan 20, 2023
@Pytal Pytal deleted the release/v7.5.0 branch January 20, 2023 00:53
@Pytal
Copy link
Contributor Author

Pytal commented Jan 20, 2023

Able to release as admin @skjnldsv? https://github.com/nextcloud/nextcloud-vue/actions/runs/3963753999

@Pytal
Copy link
Contributor Author

Pytal commented Jan 23, 2023

👆 Please ignore @skjnldsv :) Already done by @AndyScherzinger :)

@Pytal Pytal mentioned this pull request Jan 23, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @skjnldsv @raimund-schluessler @PVince81