Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] chore(master): merge master into next #4947

Merged
merged 131 commits into from
Dec 18, 2023
Merged

[next] chore(master): merge master into next #4947

merged 131 commits into from
Dec 18, 2023

Conversation

raimund-schluessler
Copy link
Contributor

☑️ Resolves

  • Merges master into next.

Antreesy and others added 30 commits November 23, 2023 09:20
@Antreesy
feat(NcInputField): add optional pill form appearance to the component
5943b7d 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@transifex-integration
Translate l10n/messages.pot in uk
7ebc0fc 
100% translated source file: 'l10n/messages.pot'
on 'uk'.
@marcoambrosini
Merge pull request #4876 from nextcloud-libraries/fix/7850/add-input-…
dcbfec1 
…pill-form

feat(NcInputField): add optional pill form appearance to the component
@susnux
Merge pull request #4879 from nextcloud-libraries/translations_ef429a…
d4bcd4c 
…9836fb49eeb7494eb2c87d1dac

Updates for project Nextcloud vue library
@ShGKme
fix(NcCheckboxRadioSwitch): visually hidden input position
8269af2 
Otherwise it is not actually positioned on the label and moved away in scrollable container.
It also may scroll the container on click.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@Pytal
Merge pull request #4882 from nextcloud-libraries/fix/checkbox-radio-…
8c16c4b 
…switch--hidden-input-position

fix(NcCheckboxRadioSwitch): visually hidden input position
@susnux
fix(NcDialog): Add slighly more padding on the bottom and fix example…
5b44909 
… button order

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Merge pull request #4881 from nextcloud-libraries/fix/ncdialog-example
415f697 
fix(NcDialog): Add slighly more padding on the bottom and fix example button order
@susnux
fix(docs): Remove internal components from styleguide
ac099f7 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(NcAppNavigationItem): Add slot documentation
f27c85a 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(NcAppNavigationCaption): Make color main-text for accessibility
c2763e2 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@ShGKme
chore(lint): use valid JSDoc for literal type union
3ac2dd5 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
fix(NcActions): typo in aria-haspopup
10cbecc 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@Pytal
Merge pull request #4883 from nextcloud-libraries/fix/nc-app-navigati…
d1dc8bc 
…on-docs

docs(NcAppNavigation): Add docs for slots and remove private components from styleguide
@ShGKme
fix(NcAppNavigation): replace v-tooltip with native title
66392b2 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@Pytal
Merge pull request #4888 from nextcloud-libraries/fix/nc-app-navigati…
d9d3e74 
…on--remove-v-tooltip

fix(NcAppNavigation): replace custom `v-tooltip` with native `title`
@ShGKme
fix(NcColorPicker): correct aria-label
79e6885 
`aria-label` should be set directly on the element being labelled.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@susnux
Merge pull request #4885 from nextcloud-libraries/fix/app-navigation-…
ea6ba30 
…caption-color

fix(NcAppNavigationCaption): Make color `main-text` for accessibility
@nextcloud-command
chore(assets): Update styling from server
a8295fa 
Signed-off-by: GitHub <noreply@github.com>
@susnux
Merge pull request #4889 from nextcloud-libraries/fix/nc-color-picker…
40a84dc 
…--correct-aria-label

fix(NcColorPicker): correct aria-label
@transifex-integration
Translate l10n/messages.pot in it
4cfe8dc 
100% translated source file: 'l10n/messages.pot'
on 'it'.
@ShGKme
Merge pull request #4891 from nextcloud-libraries/automated/noid/serv…
26eec37 
…er-styling-update

Automated styling update from server
@ShGKme
Merge pull request #4895 from nextcloud-libraries/translations_ef429a…
1008221 
…9836fb49eeb7494eb2c87d1dac

Updates for project Nextcloud vue library
@susnux
Merge pull request #4887 from nextcloud-libraries/fix/nc-actions--typ…
dae6dd9 
…o-in-aria-haspopup

fix(NcActions): typo in aria-haspopup
@susnux
Merge pull request #4886 from nextcloud-libraries/chore/lint
81641b3 
chore(lint): use valid JSDoc for literal type union
@susnux
fix(NcDialog): Increase specificity for modal-content selector
bb54cd2 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Prepare new release 8.3.0
bea531b 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Merge pull request #4898 from nextcloud-libraries/chore/prepare-release
eee1bb8 
chore: Prepare new release 8.3.0
@ShGKme
Merge pull request #4897 from nextcloud-libraries/fix/modal-styles
5cc6c04 
fix(NcDialog): Increase specificity for modal-content selector
@susnux
enh: Add a full labelled color palette to be used as the default for …
8d1b3ff 
…the color picker

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@raimund-schluessler
Merge pull request #4952 from nextcloud-libraries/refactor/nc-app-sid…
93c5a29 
…ebar--remove-debug-log

refactor(NcAppSidebar): remove unneeded debug log
@ShGKme
fix(NcAppSettingsDialog): respect showNavigation prop
a0db712 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
test: add resizeWindowWidth util
d54ff77 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
Merge pull request #4946 from nextcloud-libraries/fix/NcActions--prov…
ebbe5c6 
…ide-aria-expanded-false

fix(NcActions): provide `aria-expanded="false"` when menu is closed instead of removing it
@susnux
fix(NcActionX): Allow relative icon URL
ed9451b 
Most API returns relative icon URLs so we should also support them for NcActionXXX

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(NcListItem): Ensure list item does not overflow wrapper due to wi…
2410c0b 
…dth 100% and padding

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor

susnux commented Dec 13, 2023

@susnux Do you have an idea why cypress complains about typescript here?

No idea why this is caused by this changes but this means somehow ts-node is not called correctly. Or better: There is a mixup of ESM and CJS.
I guess because our package.json implicitly states commonjs but the configuration file is ESM, thus for ts-node it should be called .mts but cypress does not support this extension.

So there are two options:

  1. Move configuration to .mjs
  2. Make the package ESM by default (add type: "module" to the package.json).

For the next version / the next branch I would prefer the second solution, but when applied on current master then the first one so it is not a breaking change.

@ShGKme
Copy link
Contributor

ShGKme commented Dec 13, 2023

For the next version / the next branch I would prefer the second solution, but when applied on current master then the first one so it is not a breaking change.

What may break the second one?

@raimund-schluessler
Copy link
Contributor Author

I would propose to fix and merge #4930 first. Then it will work here as well.

@susnux
Copy link
Contributor

susnux commented Dec 13, 2023

What may break the second one?

I can not think of any but it changes the the package type thus I thought it might be considered breaking.

@susnux susnux mentioned this pull request Dec 13, 2023
Merged
2 tasks
Pytal and others added 12 commits December 14, 2023 12:22
@Pytal
Merge pull request #4956 from nextcloud-libraries/fix/list-item-overflow
0209e02 
fix(NcListItem): Ensure list item does not overflow wrapper
@susnux
fix(NcAppNavigation): Bring back hover state for active element
9e4fc7a 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@Pytal
Merge pull request #4955 from nextcloud-libraries/fix/allow-relative-…
4fff857 
…icon-url

fix(NcActionX): Allow relative icon URL
@Pytal
Merge pull request #4954 from nextcloud-libraries/fix/4941/NcAppSetti…
d0a4f5b 
…ngsDialog--respect-show-navigation-prop

fix(NcAppSettingsDialog): respect showNavigation prop
@emoral435
enh(aria): changed check color to adhere to 3:1 ratio
938b6a2 
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@susnux
Merge pull request #4960 from nextcloud-libraries/fix/app-nav-item-hover
78f5179 
fix(NcAppNavigation): Bring back hover state for active element
@emoral435
Merge pull request #4958 from nextcloud-libraries/enh/make-contrast-c…
3288f79 
…lear-ARIA-CHANGE

enh(aria): changed check color to adhere to 3:1 ratio
@ShGKme
chore(ci): make Jest output colorful
c8f5ecb 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@raimund-schluessler
Merge pull request #4966 from nextcloud-libraries/chore/color-jest-on-ci
4e048b4 
chore(ci): make Jest output colorful
@ahangarha
Use logical style
9d122d0 
Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
@susnux
Merge pull request #4965 from ahangarha/use-logical-style-for-header-…
b9bb3fe 
…menu

Use logical style for NcHeaderMenu
@raimund-schluessler
Merge remote-tracking branch 'origin' into chore/noid/merge-master-next
55b334d
@raimund-schluessler
Copy link
Contributor Author

I recreated the PR without the problematic update to typescript@5.3.3 (which isn't merged into master yet anyway) and pulled in all latest changes from master. I think it should be good to merge now.

@raimund-schluessler raimund-schluessler merged commit 13b5811 into next Dec 18, 2023
15 checks passed
@raimund-schluessler raimund-schluessler deleted the chore/noid/merge-master-next branch December 18, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews vue 3 Related to the vue 3 migration
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.