Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] feat(reference): Add opt-in for interactive mode and render widgets lazy once in view #5375

Merged
merged 7 commits into from
Mar 20, 2024
Merged

[next] feat(reference): Add opt-in for interactive mode and render widgets lazy once in view #5375

merged 7 commits into from
Mar 20, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Mar 8, 2024 •
edited by Antreesy
Loading

@backportbot backportbot bot added enhancement New feature or request 3. to review Waiting for reviews labels Mar 8, 2024
@Antreesy Antreesy mentioned this pull request Mar 8, 2024
Merged
@Antreesy Antreesy force-pushed the backport/5257/next branch from b02e143 to 0fae171 Compare March 15, 2024 16:19
juliusknorr and others added 7 commits March 15, 2024 17:25
@juliusknorr @Antreesy
feat(reference): Add opt-in for interactive mode and render widgets l…
9c4186e 
…azy once in view

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr @Antreesy
fix: Align interactive toggle button on top of widgets
ea6b3d6 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr @Antreesy
fix: move to typescript
6c01ac7 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr @Antreesy
feat: Implement full width support for widgets
83a778b 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr @Antreesy
fix: Only show opt in if requested
3c2528d 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@susnux @Antreesy
fix(NcReferenceWidget): Only use composables in setup context
b3c9e47 
This also should fix issues with Vue3 where `this.$el` is not always a defined real node.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@Antreesy
fix(NcReferenceWidget): set timeout to destroy idle widgets outside o…
861b0b1 
…f viewports

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the backport/5257/next branch from 0fae171 to 861b0b1 Compare March 15, 2024 16:27
@Antreesy Antreesy added this to the 9.0.0-alpha.3 milestone Mar 15, 2024
@Antreesy Antreesy marked this pull request as ready for review March 15, 2024 16:28
@susnux susnux merged commit 75e43a0 into next Mar 20, 2024
19 checks passed
@susnux susnux deleted the backport/5257/next branch March 20, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@ShGKme ShGKme ShGKme approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees

@juliusknorr juliusknorr

Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
9.0.0-alpha.3
Development

Successfully merging this pull request may close these issues.
4 participants
@ShGKme @Antreesy @susnux @juliusknorr