Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcReferenceWidget): set timeout to destroy idle widgets outside of viewports #5411

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 15, 2024

☑️ Resolves

  • Fix flickering widgets moving in an out of viewport (Talk chat)
    • When widget is out if view, a timer is set for 3 minutes (in case user scrolls back to it). If after timeout widget is still not visible, we destroy it, and it has to be rendered again
    • If widget is already rendered, we don't trigger the render method

🖼️ Screenshots

Sorry for bad sccreencast:
🏚️ Before - re-rendered each time

before.webm

🏡 After - re-rendered only if new or after 3 minutes

after.webm

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

…f viewports

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Mar 15, 2024
@Antreesy Antreesy added this to the 8.10.1 milestone Mar 15, 2024
@Antreesy Antreesy self-assigned this Mar 15, 2024
Copy link
Contributor

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Antreesy

@Antreesy Antreesy merged commit 51b1027 into master Mar 15, 2024
18 checks passed
@Antreesy Antreesy deleted the fix/noid/reference-widget-idle branch March 15, 2024 15:54
@ShGKme ShGKme modified the milestones: 8.10.1, 8.11.0 Mar 15, 2024
@Antreesy Antreesy mentioned this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: richtext Related to the richtext component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants