-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcActions): Show last action entry only partial to make it discoverable #5448
Conversation
9651b90
to
6974cf2
Compare
cc @nextcloud-libraries/designers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screenshots look good to me :)
(but didnt test and didnt review the code)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with different viewport heights and works nicely!
…erable 1. Fix wrong event name - the event is named `apply-show` and not `after-show` 2. If the popover content is too large and will be capped (max-height) make sure the last element is shown only partially, so users can discover there is more to scroll. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
6974cf2
to
04811b1
Compare
/backport to next |
Yes but that is a different story and should be handled as its own. This only fixes menus overflowing our "maximum" to show the last one half. |
Actually not sure, we do change the event name by catching it in the |
We also forward all listeners so we should be good either way. But seems you are right... |
☑️ Resolves
apply-show
and notafter-show
🖼️ Screenshots
See that before you can not see any hint of the overflow:
🏁 Checklist
next
requested with a Vue 3 upgrade