Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] fix(NcActions): Show last action entry only partial to make it discoverable #5464

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Apr 9, 2024

Backport of #5448

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from Pytal, szaimen and susnux April 9, 2024 21:03
@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components labels Apr 9, 2024
…erable

1. Fix wrong event name - the event is named `apply-show` and not `after-show`

2. If the popover content is too large and will be capped (max-height) make sure the last element is shown only partially, so users can discover there is more to scroll.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the backport/5448/next branch from 49b073a to dbcf74b Compare April 9, 2024 22:04
@susnux susnux requested a review from ShGKme April 9, 2024 22:04
@susnux susnux marked this pull request as ready for review April 9, 2024 22:04
@Pytal Pytal merged commit c12a26d into next Apr 9, 2024
18 checks passed
@Pytal Pytal deleted the backport/5448/next branch April 9, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: actions Related to the actions components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants