Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAvatar): extend variable size of status icons #5959

Merged
merged 2 commits into from
Aug 14, 2024
Merged

fix(NcAvatar): extend variable size of status icons #5959

merged 2 commits into from
Aug 14, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 14, 2024 •
edited
Loading

☑️ Resolves

  • Fix overlapping of status icons on small-sized avatars

🖼️ Screenshots

🏠 Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy
chore(docs): extend NcAvatar docs with different status icon and sizes
c679820 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added 3. to review Waiting for reviews design Design, UX, interface and interaction design feature: avatar Related to the avatar component labels Aug 14, 2024
@Antreesy Antreesy added this to the 8.16.1 milestone Aug 14, 2024
@Antreesy Antreesy self-assigned this Aug 14, 2024
@Antreesy
fix(NcAvatar): extend variable size for user statuses
69cc5dd 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/relative-user-status-size branch from bf8eee0 to 69cc5dd Compare August 14, 2024 09:59
@ShGKme ShGKme added the bug Something isn't working label Aug 14, 2024
ShGKme
ShGKme approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

marcoambrosini
marcoambrosini approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Antreesy Antreesy merged commit e8ce5f4 into master Aug 14, 2024
19 checks passed
@Antreesy Antreesy deleted the fix/noid/relative-user-status-size branch August 14, 2024 11:16
@Antreesy
Copy link
Contributor Author

/backport to next

@backportbot backportbot bot mentioned this pull request Aug 14, 2024
Merged
@Antreesy Antreesy mentioned this pull request Aug 15, 2024
Merged
5 tasks
@susnux susnux mentioned this pull request Aug 20, 2024
Merged
@susnux susnux modified the milestones: 8.16.1, 8.17.0 Aug 20, 2024
@ShGKme ShGKme mentioned this pull request Aug 22, 2024
Draft
3 tasks
@Stanislav1975 Stanislav1975 mentioned this pull request Sep 11, 2024
Open
@Antreesy Antreesy mentioned this pull request Sep 16, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: avatar Related to the avatar component
Projects
None yet
Milestone
8.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Antreesy @ShGKme @marcoambrosini @susnux