Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAvatar): add a fallback for missing CSS variable #6090

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix(NcAvatar): add a fallback for missing CSS variable #6090

merged 1 commit into from
Sep 16, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 16, 2024 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy
fix(NcAvatar): add a fallback for missing CSS variable
d9a6165 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: avatar Related to the avatar component labels Sep 16, 2024
@Antreesy Antreesy added this to the 8.18.1 milestone Sep 16, 2024
@Antreesy Antreesy self-assigned this Sep 16, 2024
@Antreesy
Copy link
Contributor Author

/backport to next

@susnux susnux merged commit 54e34d4 into master Sep 16, 2024
19 checks passed
@susnux susnux deleted the fix/5959/stable-fallback branch September 16, 2024 11:24
@backportbot backportbot bot mentioned this pull request Sep 16, 2024
Merged
@Antreesy Antreesy mentioned this pull request Sep 16, 2024
Merged
@susnux susnux modified the milestones: 8.18.1, 8.19.0 Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working feature: avatar Related to the avatar component
Projects
None yet
Milestone
8.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @susnux @DorraJaouad