Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update PSR container to 2.0.2 #1311

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 8, 2023

As requested per: nextcloud/server#36417 (comment)

This requires updating symfony/service-contracts to 3.x, which is only supported by symfony/console >= 5.4.
Updated both dependencies, php must now be at least 8.0.2.

Companion server PR: nextcloud/server#36617

@ChristophWurst
Copy link
Member

Please open a companion server PR so the CI suite tests the bump

susnux added a commit to nextcloud/server that referenced this pull request Feb 8, 2023
…rdparty#1311

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
@@ -8,7 +8,7 @@
"optimize-autoloader": true,
"classmap-authoritative": true,
"platform": {
"php": "8.0"
"php": "8.0.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to clarify if we can do that. :(

Copy link
Contributor Author

@susnux susnux Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required because of symfony/service-contracts : https://github.com/symfony/service-contracts/blob/d78d39c1599bd1188b8e26bb341da52c3c6d8a66/composer.json#L19

(that link should point to the v3 tag)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required because of symfony/service-contracts

I guessed so, but Nextcloud 26/27 require PHP 8.0 that is what we announced and told everywhere. We never required a specific patch version later on in the process :/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not that into composer configs, but if I understand that setting correctly it just sets a php version for packages. So with this setting only packages supporting php 8.0.2 are installed, but it should not affect the runtime (?)
Meaning it should be still possible to run Nextcloud with e.g. PHP 8.0.1

But as I said this is not my area expertise

Copy link
Contributor Author

@susnux susnux Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickvergessen could you clarify if this is possible for NC 27?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

symfony/symfony#41282 (comment) was the original reason for the oddly specific minimum version

@susnux susnux added the main label Feb 8, 2023
@come-nc come-nc removed their request for review March 14, 2023 16:00
@susnux susnux force-pushed the update/psr-container branch from e35f92a to 1a904a3 Compare March 16, 2023 12:42
susnux added a commit to nextcloud/server that referenced this pull request Mar 16, 2023
…rdparty#1311

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
This requires updating `symfony/service-contracts` to 3.x,
which is only supported by `symfony/console` >= 5.4.
Updated both dependencies, php must now be at least 8.0.2.

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
@susnux susnux force-pushed the update/psr-container branch from 1a904a3 to fcc8060 Compare April 17, 2023 16:32
susnux added a commit to nextcloud/server that referenced this pull request Apr 17, 2023
…rdparty#1311

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
@szaimen
Copy link

szaimen commented Apr 18, 2023

Merge?

@susnux
Copy link
Contributor Author

susnux commented Apr 18, 2023

I dug through the changes of symphony but there is nothing that depends on that explicit bug fix release.
So it looks the php requirement can be ignored, that setting does not affect runtime, only if you try to run composer to install the dependencies (e.g. CI) with php < 8.0.2 you will need to add (--ignore-platform-reqs).

But as the server PR CIs ran successfully, it seems that is not the case for our CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants