-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update PSR container to 2.0.2 #1311
Conversation
e676c58
to
e35f92a
Compare
Please open a companion server PR so the CI suite tests the bump |
…rdparty#1311 Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
@@ -8,7 +8,7 @@ | |||
"optimize-autoloader": true, | |||
"classmap-authoritative": true, | |||
"platform": { | |||
"php": "8.0" | |||
"php": "8.0.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will have to clarify if we can do that. :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required because of symfony/service-contracts : https://github.com/symfony/service-contracts/blob/d78d39c1599bd1188b8e26bb341da52c3c6d8a66/composer.json#L19
(that link should point to the v3 tag)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required because of symfony/service-contracts
I guessed so, but Nextcloud 26/27 require PHP 8.0 that is what we announced and told everywhere. We never required a specific patch version later on in the process :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not that into composer configs, but if I understand that setting correctly it just sets a php version for packages. So with this setting only packages supporting php 8.0.2 are installed, but it should not affect the runtime (?)
Meaning it should be still possible to run Nextcloud with e.g. PHP 8.0.1
But as I said this is not my area expertise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nickvergessen could you clarify if this is possible for NC 27?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
symfony/symfony#41282 (comment) was the original reason for the oddly specific minimum version
e35f92a
to
1a904a3
Compare
…rdparty#1311 Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
This requires updating `symfony/service-contracts` to 3.x, which is only supported by `symfony/console` >= 5.4. Updated both dependencies, php must now be at least 8.0.2. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
1a904a3
to
fcc8060
Compare
…rdparty#1311 Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Merge? |
I dug through the changes of symphony but there is nothing that depends on that explicit bug fix release. But as the server PR CIs ran successfully, it seems that is not the case for our CI. |
As requested per: nextcloud/server#36417 (comment)
This requires updating
symfony/service-contracts
to 3.x, which is only supported bysymfony/console
>= 5.4.Updated both dependencies, php must now be at least 8.0.2.
Companion server PR: nextcloud/server#36617