Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update PSR container to 2.0.2 #1311

Merged
merged 1 commit into from
Apr 18, 2023
Merged

chore: Update PSR container to 2.0.2 #1311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"optimize-autoloader": true,
"classmap-authoritative": true,
"platform": {
"php": "8.0"
"php": "8.0.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to clarify if we can do that. :(

Copy link
Contributor Author

@susnux susnux Feb 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required because of symfony/service-contracts : https://github.com/symfony/service-contracts/blob/d78d39c1599bd1188b8e26bb341da52c3c6d8a66/composer.json#L19

(that link should point to the v3 tag)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required because of symfony/service-contracts

I guessed so, but Nextcloud 26/27 require PHP 8.0 that is what we announced and told everywhere. We never required a specific patch version later on in the process :/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not that into composer configs, but if I understand that setting correctly it just sets a php version for packages. So with this setting only packages supporting php 8.0.2 are installed, but it should not affect the runtime (?)
Meaning it should be still possible to run Nextcloud with e.g. PHP 8.0.1

But as I said this is not my area expertise

Copy link
Contributor Author

@susnux susnux Mar 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickvergessen could you clarify if this is possible for NC 27?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

symfony/symfony#41282 (comment) was the original reason for the oddly specific minimum version

},
"sort-packages": true,
"allow-plugins": {
Expand Down Expand Up @@ -43,14 +43,14 @@
"phpseclib/phpseclib": "^2.0.40",
"pimple/pimple": "^3.5.0",
"psr/clock": "^1.0",
"psr/container": "^1.1.1",
"psr/container": "^2.0.2",
"psr/event-dispatcher": "^1.0",
"punic/punic": "^1.6",
"sabre/dav": "^4.4.0",
"scssphp/scssphp": "^1.11",
"stecman/symfony-console-completion": "^0.11.0",
"swiftmailer/swiftmailer": "^6.3.0",
"symfony/console": "4.4.30",
"symfony/console": "5.4.19",
"symfony/event-dispatcher": "4.4.30",
"symfony/event-dispatcher-contracts": "1.1.9",
"symfony/http-foundation": "^5.4.10",
Expand Down
172 changes: 137 additions & 35 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading