Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] Continuous Integration / Clean code #5368

Open
5 of 8 tasks
docjyJ opened this issue Oct 2, 2024 · 2 comments
Open
5 of 8 tasks

[PHP] Continuous Integration / Clean code #5368

docjyJ opened this issue Oct 2, 2024 · 2 comments
Labels
2. developing Work in progress enhancement New feature or request long term overview Overview of other issues technical debt

Comments

@docjyJ
Copy link
Collaborator

docjyJ commented Oct 2, 2024

Is your feature request related to a problem? Please describe.

Nextcloud all in one is an old project with lots of features. The idea is to update its code by taking advantage of psalm's type checking, a new feature introduced by PHP.

Describe the solution you'd like

Use: https://github.com/nextcloud/coding-standard
Go to level 1: https://psalm.dev/docs/running_psalm/error_levels/
See: https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/continuous_integration.html

Describe alternatives you've considered

Additional context

I will add more info to this issue when I have time.

@docjyJ docjyJ added 2. developing Work in progress enhancement New feature or request long term labels Oct 2, 2024
@szaimen szaimen added overview Overview of other issues technical debt labels Oct 2, 2024
@szaimen szaimen changed the title --WIP-- [PHP] Continuous Integration / Clean code [PHP] Continuous Integration / Clean code Oct 2, 2024
szaimen added a commit that referenced this issue Oct 4, 2024
Follow up already noted in #5368

Signed-off-by: Simon L. <szaimen@e.mail.de>
@docjyJ
Copy link
Collaborator Author

docjyJ commented Dec 4, 2024

With php 8.4 we could simplify classes to reduce code weight. The Container class could benefit greatly from this.

By using the Asymmetric Visibility:
https://www.php.net/releases/8.4/en.php

ref #5699

@szaimen
Copy link
Collaborator

szaimen commented Dec 4, 2024

With php 8.4 we could simplify classes to reduce code weight. The Container class could benefit greatly from this.

By using the Asymmetric Visibility: https://www.php.net/releases/8.4/en.php

Looks really cool! 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement New feature or request long term overview Overview of other issues technical debt
Projects
None yet
Development

No branches or pull requests

2 participants