Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nextcloud/coding-standard dependency #5370

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add nextcloud/coding-standard dependency #5370

wants to merge 1 commit into from

Conversation

docjyJ
Copy link
Collaborator

@docjyJ docjyJ commented Oct 2, 2024

Add nextcloud/coding-standard

Attention, all files are affected!

Found 43 of 43 files that can be fixed in 4.645 seconds, 18.00 MB memory used
Script php-cs-fixer fix --dry-run --diff handling the cs:check event returned with error code 8

@docjyJ docjyJ added 3. to review Waiting for reviews enhancement New feature or request labels Oct 2, 2024
@docjyJ docjyJ requested a review from szaimen October 2, 2024 12:12
@docjyJ docjyJ self-assigned this Oct 2, 2024
@docjyJ
Copy link
Collaborator Author

docjyJ commented Oct 2, 2024

I split into 2 commits:

@docjyJ docjyJ added this to the next milestone Oct 2, 2024
@docjyJ docjyJ force-pushed the enh/noid/cs branch 2 times, most recently from e25c6da to 38a5aa8 Compare October 2, 2024 16:33
@szaimen
Copy link
Collaborator

szaimen commented Oct 4, 2024

Thanks again for your contributions @docjyJ! I think this looks good but probably makes sense to wait for e.g. this PR: #4804 as otherwise it will be a rebase hell...

@szaimen szaimen marked this pull request as draft October 4, 2024 13:34
Signed-off-by: Jean-Yves <7360784+docjyJ@users.noreply.github.com>
@docjyJ
Copy link
Collaborator Author

docjyJ commented Oct 4, 2024

Yes, I know, complicated to merge. Since it's only style, it must not be the worst case.

I dropped the commit from run cs:fix and rebased the branch.

@docjyJ docjyJ removed this from the next milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants