-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate OwncloudClient - Notifications #1272
Conversation
04e37e2
to
fa0c017
Compare
fa0c017
to
0908746
Compare
Hello there, We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
64c5e92
to
23cce55
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1272 +/- ##
============================================
+ Coverage 47.56% 49.28% +1.71%
- Complexity 977 1002 +25
============================================
Files 208 208
Lines 7850 7830 -20
Branches 1019 1015 -4
============================================
+ Hits 3734 3859 +125
+ Misses 3580 3417 -163
- Partials 536 554 +18
|
23cce55
to
d35a249
Compare
d35a249
to
96f44ff
Compare
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
96f44ff
to
f810162
Compare
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
This is one of a series of pull requests which aim to replace all instances of
OwnCloudClient
withNextcloudClient
. The reason for this change is that the newerNextcloudClient
uses OkHttp, replacing the outdated Jackrabbit methods.Specifically, this pull request implements the following: