Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate OwncloudClient - Notifications #1272

Merged
merged 8 commits into from
Jun 11, 2024
Merged

Conversation

ZetaTom
Copy link
Contributor

@ZetaTom ZetaTom commented Dec 11, 2023

This is one of a series of pull requests which aim to replace all instances of OwnCloudClient with NextcloudClient. The reason for this change is that the newer NextcloudClient uses OkHttp, replacing the outdated Jackrabbit methods.

Specifically, this pull request implements the following:

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@ZetaTom ZetaTom force-pushed the depocc/notifications branch 2 times, most recently from 64c5e92 to 23cce55 Compare January 10, 2024 09:54
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: Patch coverage is 44.26230% with 34 lines in your changes missing coverage. Please review.

Project coverage is 49.28%. Comparing base (a5b967b) to head (f93e00f).
Report is 4 commits behind head on master.

Current head f93e00f differs from pull request most recent head d93c23e

Please upload reports for the commit d93c23e to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1272      +/-   ##
============================================
+ Coverage     47.56%   49.28%   +1.71%     
- Complexity      977     1002      +25     
============================================
  Files           208      208              
  Lines          7850     7830      -20     
  Branches       1019     1015       -4     
============================================
+ Hits           3734     3859     +125     
+ Misses         3580     3417     -163     
- Partials        536      554      +18     
Files Coverage Δ
...tPredefinedCustomStatusMessageRemoteOperation.java 61.90% <100.00%> (ø)
.../lib/resources/users/SetStatusRemoteOperation.java 61.11% <100.00%> (-2.05%) ⬇️
...ib/resources/users/SetUserInfoRemoteOperation.java 85.29% <100.00%> (-2.59%) ⬇️
...ations/RegisterAccountDeviceForProxyOperation.java 0.00% <0.00%> (ø)
...ions/UnregisterAccountDeviceForProxyOperation.java 0.00% <0.00%> (ø)
...UserDefinedCustomStatusMessageRemoteOperation.java 65.21% <71.42%> (+1.58%) ⬆️
.../notifications/GetNotificationRemoteOperation.java 72.41% <50.00%> (+5.74%) ⬆️
...notifications/GetNotificationsRemoteOperation.java 70.37% <50.00%> (+5.85%) ⬆️
...cations/DeleteAllNotificationsRemoteOperation.java 55.55% <50.00%> (+55.55%) ⬆️
...tifications/DeleteNotificationRemoteOperation.java 60.00% <42.85%> (+60.00%) ⬆️
... and 2 more

... and 16 files with indirect coverage changes

@ZetaTom ZetaTom mentioned this pull request Jan 30, 2024
7 tasks
@ZetaTom ZetaTom force-pushed the depocc/notifications branch from 23cce55 to d35a249 Compare January 30, 2024 10:53
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@ZetaTom ZetaTom force-pushed the depocc/notifications branch from d35a249 to 96f44ff Compare June 3, 2024 12:10
Copy link
Contributor

github-actions bot commented Jun 3, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

ZetaTom added 5 commits June 10, 2024 15:40
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
@tobiasKaminsky tobiasKaminsky self-requested a review June 10, 2024 13:41
@tobiasKaminsky tobiasKaminsky marked this pull request as ready for review June 10, 2024 13:41
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@tobiasKaminsky tobiasKaminsky merged commit cda1b08 into master Jun 11, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants