Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate OwncloudClient - DirectEditing #12267

Merged
merged 7 commits into from
Jun 12, 2024
Merged

Conversation

ZetaTom
Copy link
Collaborator

@ZetaTom ZetaTom commented Dec 11, 2023

This is one of a series of pull requests which aim to replace all instances of OwnCloudClient with NextcloudClient. The reason for this change is that the newer NextcloudClient uses OkHttp, replacing the outdated Jackrabbit methods.

Specifically, this pull request implements the following:


  • Tests written, or not not needed

@ZetaTom ZetaTom self-assigned this Dec 11, 2023
@ZetaTom ZetaTom force-pushed the depocc/directediting branch from fa24499 to 54e590f Compare December 20, 2023 09:26
@ZetaTom ZetaTom force-pushed the depocc/directediting branch 3 times, most recently from c899052 to 1d5b736 Compare January 10, 2024 10:09
@ZetaTom ZetaTom force-pushed the depocc/directediting branch from 1d5b736 to c6580de Compare January 30, 2024 10:33
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

ZetaTom and others added 7 commits June 12, 2024 10:48
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Copy link

Codacy

Lint

TypemasterPR
Warnings6969
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6868
Dodgy code344344
Experimental11
Internationalization77
Multithreaded correctness66
Performance5757
Security1818
Total565565

Copy link

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12267.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@tobiasKaminsky tobiasKaminsky merged commit 52751d5 into master Jun 12, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants