Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate OwncloudClient - DirectEditing #1273

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Conversation

ZetaTom
Copy link
Contributor

@ZetaTom ZetaTom commented Dec 11, 2023

This is one of a series of pull requests which aim to replace all instances of OwnCloudClient with NextcloudClient. The reason for this change is that the newer NextcloudClient uses OkHttp, replacing the outdated Jackrabbit methods.

Specifically, this pull request implements the following:

@ZetaTom ZetaTom self-assigned this Dec 11, 2023
@ZetaTom ZetaTom force-pushed the depocc/directediting branch 3 times, most recently from f352a73 to d06faa6 Compare December 12, 2023 13:45
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: Patch coverage is 71.79487% with 11 lines in your changes missing coverage. Please review.

Project coverage is 49.25%. Comparing base (cda1b08) to head (4a78745).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1273      +/-   ##
============================================
- Coverage     49.28%   49.25%   -0.04%     
- Complexity     1002     1003       +1     
============================================
  Files           208      208              
  Lines          7830     7823       -7     
  Branches       1015     1015              
============================================
- Hits           3859     3853       -6     
- Misses         3417     3418       +1     
+ Partials        554      552       -2     
Files Coverage Δ
...ectediting/DirectEditingObtainRemoteOperation.java 60.86% <50.00%> (+0.86%) ⬆️
...tediting/DirectEditingOpenFileRemoteOperation.java 80.76% <83.33%> (-0.72%) ⬇️
...diting/DirectEditingCreateFileRemoteOperation.java 78.12% <76.92%> (+1.65%) ⬆️
...ctEditingObtainListOfTemplatesRemoteOperation.java 64.00% <60.00%> (+1.03%) ⬆️

... and 3 files with indirect coverage changes

@ZetaTom ZetaTom force-pushed the depocc/directediting branch from d06faa6 to ed90690 Compare December 20, 2023 09:26
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@ZetaTom ZetaTom force-pushed the depocc/directediting branch 2 times, most recently from 3b794da to 7492e14 Compare January 10, 2024 09:55
@ZetaTom ZetaTom force-pushed the depocc/directediting branch from 7492e14 to 611d071 Compare January 30, 2024 10:36
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

tobiasKaminsky
tobiasKaminsky previously approved these changes Jun 11, 2024
ZetaTom and others added 4 commits June 11, 2024 12:23
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky tobiasKaminsky self-requested a review June 11, 2024 10:26
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@tobiasKaminsky tobiasKaminsky merged commit 354911a into master Jun 11, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants