Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public sharing: ask for password #294

Merged
merged 1 commit into from
May 10, 2019
Merged

public sharing: ask for password #294

merged 1 commit into from
May 10, 2019

Conversation

tobiasKaminsky
Copy link
Member

Needed for nextcloud/android#3989

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud nextcloud deleted a comment May 10, 2019
@nextcloud-android-bot
Copy link
Collaborator

Lint

TypemasterPR
Warnings00
Errors00

FindBugs (new)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings42
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings22
Security Warnings17
Dodgy code Warnings84
Total195

FindBugs (master)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings42
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings22
Security Warnings17
Dodgy code Warnings84
Total195

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #294 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
- Coverage      18%   17.97%   -0.03%     
==========================================
  Files         121      121              
  Lines        5266     5273       +7     
  Branches      722      723       +1     
==========================================
  Hits          948      948              
- Misses       4183     4190       +7     
  Partials      135      135
Impacted Files Coverage Δ
...oud/android/lib/resources/status/OCCapability.java 0% <0%> (ø) ⬆️
...sources/status/GetRemoteCapabilitiesOperation.java 0% <0%> (ø) ⬆️

@AndyScherzinger AndyScherzinger merged commit 7b8b392 into master May 10, 2019
@AndyScherzinger AndyScherzinger deleted the askForPassword branch May 10, 2019 20:59
@AndyScherzinger AndyScherzinger added this to the NC Android lib 1.5.0 milestone May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants