Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public share: if ask for password is set, show an optional password dialog #3989

Merged
merged 6 commits into from
May 14, 2019

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented May 9, 2019

Ref:

This is a new capability, starting with NC17.
As the current behaviour is to not show any dialog, it is ok to add it right now.
If the flag is set (see below), then it will be used.

image

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@tobiasKaminsky
Copy link
Member Author

Will wait for final decision on capability name.

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #3989 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #3989      +/-   ##
===========================================
- Coverage      6.61%   6.57%   -0.04%     
  Complexity        1       1              
===========================================
  Files           326     322       -4     
  Lines         30930   30946      +16     
  Branches       4409    4412       +3     
===========================================
- Hits           2045    2036       -9     
- Misses        28588   28615      +27     
+ Partials        297     295       -2
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/owncloud/android/db/ProviderMeta.java 84.61% <ø> (ø) 0 <0> (ø) ⬇️
...android/ui/dialog/SharePasswordDialogFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...loud/android/datamodel/FileDataStorageManager.java 11.92% <0%> (-0.04%) 0 <0> (ø)
...om/owncloud/android/ui/activity/ShareActivity.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...om/owncloud/android/ui/dialog/SendShareDialog.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...wncloud/android/providers/FileContentProvider.java 19.13% <0%> (-0.23%) 0 <0> (ø)
...android/ui/fragment/FileDetailSharingFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...cloud/android/ui/activity/FileDisplayActivity.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...wncloud/android/ui/fragment/ShareFileFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...cloud/android/ui/helpers/FileOperationsHelper.java 0% <0%> (ø) 0 <0> (ø) ⬇️
... and 17 more

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #3989 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #3989      +/-   ##
===========================================
- Coverage       6.7%   6.68%   -0.02%     
  Complexity        1       1              
===========================================
  Files           326     326              
  Lines         30884   30915      +31     
  Branches       4406    4409       +3     
===========================================
- Hits           2070    2068       -2     
- Misses        28516   28547      +31     
- Partials        298     300       +2
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/owncloud/android/db/ProviderMeta.java 84.61% <ø> (ø) 0 <0> (ø) ⬇️
...android/ui/dialog/SharePasswordDialogFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...loud/android/datamodel/FileDataStorageManager.java 11.85% <0%> (-0.05%) 0 <0> (ø)
...om/owncloud/android/ui/activity/ShareActivity.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...om/owncloud/android/ui/dialog/SendShareDialog.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...wncloud/android/providers/FileContentProvider.java 18.91% <0%> (-0.22%) 0 <0> (ø)
...android/ui/fragment/FileDetailSharingFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...cloud/android/ui/activity/FileDisplayActivity.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...wncloud/android/ui/fragment/ShareFileFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...cloud/android/ui/helpers/FileOperationsHelper.java 0% <0%> (ø) 0 <0> (ø) ⬇️
... and 1 more

@nextcloud-android-bot
Copy link
Collaborator

Codacy

279

Lint

TypemasterPR
Warnings5858
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings79
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings174
Security Warnings47
Dodgy code Warnings140
Total490

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings79
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings174
Security Warnings47
Dodgy code Warnings141
Total491

Android-library is not set to master branch in build.gradle

@AndyScherzinger
Copy link
Member

@tobiasKaminsky needs another rebase to resolve latest conflicts

@nextcloud-android-bot
Copy link
Collaborator

Codacy

284

Lint

TypemasterPR
Warnings5858
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings79
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings122
Security Warnings47
Dodgy code Warnings140
Total438

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings79
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings122
Security Warnings47
Dodgy code Warnings140
Total438

tobiasKaminsky and others added 6 commits May 14, 2019 13:23
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
… [skip ci]

Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

Codacy

284

Lint

TypemasterPR
Warnings5858
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings79
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings122
Security Warnings47
Dodgy code Warnings140
Total438

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings79
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings122
Security Warnings47
Dodgy code Warnings140
Total438

@AndyScherzinger AndyScherzinger merged commit b4f36f4 into master May 14, 2019
@AndyScherzinger AndyScherzinger deleted the askForPassword branch May 14, 2019 12:34
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.7.0 milestone May 14, 2019
tobiasKaminsky added a commit that referenced this pull request May 15, 2019
b4f36f4 Merge pull request #3989 from nextcloud/askForPassword
1edf2cd changes due to rebase
a0a841f revert to master branch
d372a21 combine if statement
9650a14 change capability name
788cea1 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
8f78e61 if ask for password is set, show an optional password dialog
3b24d09 daily dev 20190514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants