-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public share: if ask for password is set, show an optional password dialog #3989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Will wait for final decision on capability name. |
tobiasKaminsky
force-pushed
the
askForPassword
branch
from
May 10, 2019 05:50
e834702
to
3f618da
Compare
Codecov Report
@@ Coverage Diff @@
## master #3989 +/- ##
===========================================
- Coverage 6.61% 6.57% -0.04%
Complexity 1 1
===========================================
Files 326 322 -4
Lines 30930 30946 +16
Branches 4409 4412 +3
===========================================
- Hits 2045 2036 -9
- Misses 28588 28615 +27
+ Partials 297 295 -2
|
Codecov Report
@@ Coverage Diff @@
## master #3989 +/- ##
===========================================
- Coverage 6.7% 6.68% -0.02%
Complexity 1 1
===========================================
Files 326 326
Lines 30884 30915 +31
Branches 4406 4409 +3
===========================================
- Hits 2070 2068 -2
- Misses 28516 28547 +31
- Partials 298 300 +2
|
Codacy279Lint
SpotBugs (new)
SpotBugs (master)
Android-library is not set to master branch in build.gradle |
@tobiasKaminsky needs another rebase to resolve latest conflicts |
tobiasKaminsky
force-pushed
the
askForPassword
branch
from
May 13, 2019 07:47
d2aff4d
to
ab98510
Compare
Codacy284Lint
SpotBugs (new)
SpotBugs (master)
|
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
… [skip ci] Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky
force-pushed
the
askForPassword
branch
from
May 14, 2019 11:28
ab98510
to
1edf2cd
Compare
Codacy284Lint
SpotBugs (new)
SpotBugs (master)
|
AndyScherzinger
approved these changes
May 14, 2019
tobiasKaminsky
added a commit
that referenced
this pull request
May 15, 2019
b4f36f4 Merge pull request #3989 from nextcloud/askForPassword 1edf2cd changes due to rebase a0a841f revert to master branch d372a21 combine if statement 9650a14 change capability name 788cea1 Drone: update FindBugs results to reflect reduced error/warning count [skip ci] 8f78e61 if ask for password is set, show an optional password dialog 3b24d09 daily dev 20190514
willpyshan13
added a commit
to willpyshan13/android
that referenced
this pull request
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref:
This is a new capability, starting with NC17.
As the current behaviour is to not show any dialog, it is ok to add it right now.
If the flag is set (see below), then it will be used.
Signed-off-by: tobiasKaminsky tobias@kaminsky.me