add "askForPassword" on capabilities for sharing #15461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
reviewed
May 9, 2019
rullzer
reviewed
May 9, 2019
Merged
1 task
tobiasKaminsky
force-pushed
the
askForPasswordCapability
branch
2 times, most recently
from
ccb144c to
0df2056
Compare
kesselb
approved these changes
May 11, 2019
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
MorrisJobke
force-pushed
the
askForPasswordCapability
branch
from
0df2056 to
b65a595
Compare
MorrisJobke
approved these changes
May 13, 2019
MorrisJobke
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #15459
This exposes "askForPassword" capability on file_sharing:
If password is enforced, askForPassword will be false.
Signed-off-by: tobiasKaminsky tobias@kaminsky.me