Password on share: enforce vs. ask

[tobiasKaminsky]

TODO

• Android: Public share: if ask for password is set, show an optional password dialog android#3989
• Desktop
• iOS
• server: NC17+

We have two different options here

• enforce: password needs to be set
  • the dialog should have no option to skip it
• always ask: ask for a password, but it is not required
  • the dialog should indicate that it is ok to skip it

Enforce vs. optional

@nextcloud/designers

[skjnldsv]

IS this a feature request? A bug? 🤔

[tobiasKaminsky]

This is a meta-issue for clients, as indicated by labels.
We agreed to have those issues centrally in server and, if needed, then individual in each repo.
Once the client is working, this should be noted here and if every client/platform has included it, we can close this.

tl;dr: for feature parity we track this here with label "client"

[tobiasKaminsky]

In capability this is:

Enforce password:

"files_sharing": {
          "api_enabled": true,
          "public": {
            "enabled": true,
            "password": {
              "enforced": true
            },

But I do not see a capability for "always ask for password"?
@nextcloud/server-triage

[tobiasKaminsky]

I added a PR to support askForPassword capability.

[jancborchardt]

The mandatory/optional state of the password could also not only be indicated by the dialog, but by the flow. If passwords are enforced, the prompt to enter the password should directly show and say something like "Passwords are mandatory".

[tobiasKaminsky]

the prompt to enter the password should directly show and say something like "Passwords are mandatory".

This is already the case. but in both cases. The only difference is the title…

[tobiasKaminsky]

So @jancborchardt are you fine with this? :-D

[jancborchardt]

Yes, sorry – I 👍’d your reply and meant that I was fine with it. :D

[joshtrichards]

Is the final unchecked item for iOS addressed in nextcloud/ios#1804 (merged & released)? If so, I think this is closable.

I'll leave this open for now until confirmed by one of you or I turn up better evidence in already merged PRs. :)

[nickvergessen]

Just close, it can be reopened when it's still not working later on.