Fix share email, not asked for password #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for password enforcement every time a new share should be created. Will display an alert. If password enforcement is off, callback returns `nil`. Signed-off-by: Henrik Storch <henrik.storch@nextcloud.com>
|
@thisIsTheFoxe , This is a new issue ? In 4.0.6 works ? |
|
@marinofaggiana Not sure about 4.0.6 but I tested it with the develop branch and got the same result as in the issue. |
|
it seems strange ... it must have worked |
|
Actually, I just also tested in on the 406 branch (8247807). Same result. Not sure why it worked for you. Please make sure you have the same sever configuration as described in the issue. Also also, not how #1792 can be seen here as well. Since the error message should be that passwords are enforced. |
|
Strange it was a previous problem corrected a long time ago ... I'm probably wrong 😑 |
marinofaggiana
approved these changes
Dec 10, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for password enforcement every time a new share should be created. Will display an alert. If password enforcement is off, callback returns
nil.