Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Downloaded files stay in tmp, not in intended location #12775

Closed
4 tasks done
kescherCode opened this issue Mar 31, 2024 · 22 comments · Fixed by #12794
Closed
4 tasks done

Regression: Downloaded files stay in tmp, not in intended location #12775

kescherCode opened this issue Mar 31, 2024 · 22 comments · Fixed by #12794
Assignees
Labels

Comments

@kescherCode
Copy link

kescherCode commented Mar 31, 2024

⚠️ Before posting ⚠️

  • This is a bug, not a question or an enhancement.
  • I've searched for similar issues and didn't find a duplicate.
  • I've written a clear and descriptive title for this issue, not just "Bug" or "Crash".
  • I agree to follow Nextcloud's Code of Conduct.

Steps to reproduce

  1. Install 3.28.1. Fresh install or upgrade from 3.28.0, does not matter.
  2. Download a file using the context menu on a file. Clicking "Sync" on a folder with server-side changes compared to the client has the same behaviour.

Expected behaviour

The file should be downloaded at the intended storage location, such as Android/media/com.nextcloud.client/[user@server]/[path]. The chosen storage location does not matter, it always happens.

Actual behaviour

Only the folder structure is recreated up until Android/media/com.nextcloud.client/[user@server]/[containing directory]. The rest remains in Android/media/com.nextcloud.client/tmp/[user@server]/[path].

Android version

14

Device brand and model

Fairphone 4

Stock or custom OS?

Custom (CalyxOS)

Nextcloud android app version

3.28.1

Nextcloud server version

27.1.8

Using a reverse proxy?

Yes

Android logs

No response

Server error logs

Not applicable

Additional information

I cannot provide logs as I don't want to upgrade to the broken 2.38.1 again. It should be fairly easy to reproduce. 2.38.0 works fine.

@kescherCode
Copy link
Author

Also still occurs in Nextcloud Dev 20240331.

@Unpublished Unpublished linked a pull request Apr 1, 2024 that will close this issue
1 task
@alperozturk96 alperozturk96 self-assigned this Apr 1, 2024
@githubtefo
Copy link

Advice: do not try to downgrade by removing the App and installing from F-Droid! All your sync data in the Android device will gone locally and you will need to re-sync everything.

@Unpublished Unpublished removed a link to a pull request Apr 2, 2024
1 task
@Unpublished Unpublished linked a pull request Apr 2, 2024 that will close this issue
1 task
@kescherCode
Copy link
Author

@githubtefo That is true, however, for me it was the only viable option to continue using the app. So I did bite the bullet and deleted that sync data.

@soundconjurer
Copy link

I am also still having this issue. It will download the file to a tmp folder and then not transfer it when it is done, thus failing to open something like a PDF.

@githubtefo
Copy link

Not sure if related, but the Nextcloud Notes App is showing issues since the same update. I had to revert to the previous version too.

@githubtefo
Copy link

oh, no! I forgot that F-Droid recently started to auto-update packages in the background 😮‍💨 I'm stuck with the non-working versions again, I won't repeat the whole re-sync process again.

@githubtefo That is true, however, for me it was the only viable option to continue using the app. So I did bite the bullet and deleted that sync data.
oh, no! I forgot that F-Droid recently started to auto-update packages in the background 😮‍💨 I'm stuck with the non-working versions again, I won't repeat the whole re-sync process again.

@Ronkn
Copy link

Ronkn commented Apr 3, 2024

Really hope this is fixed soon. Would be nice if the prior version was re-released as 2.38.2 until this is resolved.

@Ronkn
Copy link

Ronkn commented Apr 3, 2024

Not sure if related, but the Nextcloud Notes App is showing issues since the same update. I had to revert to the previous version too.

So the nextcloud notes app has an issue as well or is it just having sync issues due to this nextcloud sync app issue?

I use nextcloud notes heavily. This whole issue is a major major issue. I've been running nextcloud for 7 years and this may be the straw that makes me jump. This is basically making my whole instance unusable.

@githubtefo
Copy link

Not sure if related, but the Nextcloud Notes App is showing issues since the same update. I had to revert to the previous version too.

So the nextcloud notes app has an issue as well or is it just having sync issues due to this nextcloud sync app issue?

I use nextcloud notes heavily. This whole issue is a major major issue. I've been running nextcloud for 7 years and this may be the straw that makes me jump. This is basically making my whole instance unusable.

Agreed - Nextcloud user for 6 years in a row for my professional daily activities and this is hard to swallow.
Notes is working fine now using the stable latest version of both Apps - so I cannot tell at this point whether was a problem between different versions or a configuration issue after removing the Nextcloud App an re-setting everything again.

@danepowell
Copy link

I hate to demand anything from a free product, but I'd like to hear from the maintainers how such a show-stopping bug slipped through. It suggests that not even basic QA was performed on the release, which shakes my confidence in an otherwise lovable project.

@githubtefo
Copy link

When viewed in context, this pales in comparison to the recent stumble we've experienced in the open source community 😆 https://www.wired.com/story/jia-tan-xz-backdoor/

I hate to demand anything from a free product, but I'd like to hear from the maintainers how such a show-stopping bug slipped through. It suggests that not even basic QA was performed on the release, which shakes my confidence in an otherwise lovable project.

@brianjmurrell
Copy link

When viewed in context, this pales in comparison to the recent stumble we've experienced in the open source community 😆 https://www.wired.com/story/jia-tan-xz-backdoor/

Apples and oranges. Why are you even trying to compare a malicious code injection activity with what seems to be an apparent lack of even basic QA? They are not related on any level whatsoever.

@githubtefo
Copy link

When viewed in context, this pales in comparison to the recent stumble we've experienced in the open source community 😆 https://www.wired.com/story/jia-tan-xz-backdoor/

Apples and oranges. Why are you even trying to compare a malicious code injection activity with what seems to be an apparent lack of even basic QA? They are not related on any level whatsoever.

Fair enough.I was trying to make a bad joke to distend the frustration, my apologizes.

@danepowell
Copy link

Fair enough.I was trying to make a bad joke to distend the frustration, my apologizes.

No worries, I took it in the intended spirit 😄

@tobiasKaminsky
Copy link
Member

We have a fix and will release a new 3.28.2 today.

@kescherCode
Copy link
Author

Just linking the backport PR here: #12816

@Maxmystere
Copy link

Thank a lot for the quick response to this issue

@zerwes
Copy link

zerwes commented Apr 7, 2024

the dev version 20240404 from fdroid still suffers from the bug ...

@markusdd
Copy link

markusdd commented Apr 9, 2024

when will this arrive?? I see no update in the playstore yet. this is a major issue.

@brianjmurrell
Copy link

We have a fix and will release a new 3.28.2 today.

This was 5 days ago. Was the 3.28.2 release made 5 days ago? If so, does it really take so long from release to being installable in the Play Store?

@markusdd
Copy link

markusdd commented Apr 9, 2024

No idea, that is why I'm asking. Explicitly checked again now and I do not see this version yet.

@GillesMocellin
Copy link

Hi !
Yes ! Available on play store, and works fine again for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.