Fix upload download problems #12794
Merged
Fix upload download problems #12794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unpublished
approved these changes
Apr 2, 2024
4 tasks
|
Can you either suppress spotbugs, or manually increase count, so that CI is green? |
|
/backport to stable-3.28 |
1 task
ZetaTom
requested changes
Apr 3, 2024
Comment on lines
+53
to
+54
| return isJobScheduled || if (file.isFolder) { | ||
| backgroundJobManager.isStartFileDownloadJobScheduled(user, topParentId) |
There was a problem hiding this comment.
Shouldn't isJobScheduled be joined onto line 54 (inside the if branch) instead of line 53? Was this change made on purpose?
Otherwise this could change the return value of isDownloading().
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Co-authored-by: Tom <70907959+ZetaTom@users.noreply.github.com> Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
alperozturk96
force-pushed
the
Bugfix/upload-and-download-problems
branch
from
b91da26
to
11c24e6
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12794.apk |
tobiasKaminsky
approved these changes
Apr 4, 2024
4 tasks
|
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12794-Screenshot-blue-Light-07-32 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By Alper
This PR Fixes Following Problems
Sync icon visibility during download
Accessing after download attempt to etag throws null point exception
Remove file dialog actions order is wrong for downloaded and normal file
File download
Note
The Spotbugs count increased due to the reintroduction of old code (with improvements) in this PR.