Share dialog: set expiration date option disappeared in version 3.3.x

[mel26]

Actual behaviour

• Share file dialog does not contain option to set share expiration date
• It's impossible to set "share by link" expiration date like in desktop app and web interface
• This option was present in previous version of app (I think below 3.3), but in version 3.3.2 there is no this option

Expected behaviour

• Share file dialog contain option to set expiration date

Steps to reproduce

1. Open share dialog for file or folder
2. Share file "by link" or "by user name"
3. There is no option to set share expiration date

Environment data

Android version: 8.1, 9.0

Device model: Google Nexus 5X, Google Pixel 2XL

Stock or customized system: Stock

Nextcloud app version: 3.3.2

Nextcloud server version: 14.0.3

[nextcloud-android-bot]

GitMate.io thinks possibly related issues are #1979 (3.0RC1 Share Icon disappears), #1955 (Share permission dialog), #743 (Share Link: "Share via App" Dialog opens before set share options), #1548 (About dialog), and #3168 (Share Link: Allow editing Option not available).

[tobiasKaminsky]

For me, latest version and NC15 "expiration date" is shown for "share via link", but not for users.

[AndyScherzinger]

@tobiasKaminsky my guess is that this is a layouting problem since the whole 3-dor menu isn't shown. @mel26 what happens if you flip the device for landscape?
My guess is that this is due to the too long transtaion strings, maybe...

[tobiasKaminsky]

In all above screenshots I can see the "3-dot" menu?

[AndyScherzinger]

see first screenshot posted by @mel26 -> no 3 dow menu

[tobiasKaminsky]

ahaha. Stupid me.
I only saw the first three dot menu, but not the menu for the link…

As you are the UI pro, maybe you can have a look?

I will then have a look if and how shares to user should have an expiration date.

[AndyScherzinger]

As you are the UI pro, maybe you can have a look?

I'll have a look. Might be though that we need to have ellipsizing in place (pretty sure we need to)

[tobiasKaminsky]

We have enough vertical place…But I am unsure how this could look like in a good way…

[AndyScherzinger]

We have enough vertical place…But I am unsure how this could look like in a good way…

No idea really. We can of course try to implement this with multi-line fields which would also solve th issue and would be an alternative to ellipsizing, true.

[mel26]

You right. In horizontal orientation I can see 3-dot menu. In vertical - no.

…

-- С уважением, Павел А. Мельниченко пн, 5 нояб. 2018 г., 14:38 Andy Scherzinger notifications@github.com:

@tobiasKaminsky <https://github.com/tobiasKaminsky> my guess is that this is a layouting problem since the whole 3-dor menu isn't shown. @mel26 <https://github.com/mel26> what happens if you flip the device for landscape? My guess is that this is due to the too long transtaion strings, maybe... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3224 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIWq5Q-4nJ1YZ8ORoMzHShr7edgAYBjwks5usCM1gaJpZM4YNh1z> .

[AndyScherzinger]

looking for @nextcloud/designers' input. For the sharing dialog on Android we have the situation that (for sharing links we might have translations (like this one) where the text consumes to much space leading to the menu being hidden. We do have 2 (technical) solutions for this:

• ellipsize the text (ellipsizing middle?) so the single line item layout will be preserved while that means the texts might be shortened
• make the texts 2-line text which will lead to list items of different size or slightly different layouting (1-line Text for user shares vs. 2-line Text for link shares)

Actual situation for a non-Englisch screen:

[jancborchardt]

Yeah, we also had these space issues on the server. We decided that for links we only show:

Share link [ 📋 Copy ] •••

And the "Allow editing" checkbox needs to go into the 3-dot menu.