Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose sorting order #340

Closed
tobiasKaminsky opened this issue Oct 16, 2016 · 31 comments
Closed

Choose sorting order #340

tobiasKaminsky opened this issue Oct 16, 2016 · 31 comments

Comments

@tobiasKaminsky
Copy link
Member

Currently files can be sorted by

  • A -> Z
  • Biggest -> Smallest
  • Newest -> Oldest

This issue is about discussing if (and how) we can allow to change the sorting order.

Ideas:

  • Add 3 options with reversed order: Z -> A
    • ugly as hell -> NO
  • Second click on same order reverts sorting order
    • not understandable/visible for user
  • use fast scroll instead of reversing order
    • user can easily and fast scroll down

Option 3 is maybe independent and should be implemented anyway (#47)

@Spacefish

@AndyScherzinger
Copy link
Member

This is how Amaze file manager is doing it:
device-2016-10-17-115631

@mario
Copy link
Contributor

mario commented Jan 16, 2017

If it's not too much to ask, can you please leave the sort & filter functionality for April? I have a few issues I want to go through first, but I have a quite clear picture of how both sort and filtering should work. Thanks!

@AndyScherzinger
Copy link
Member

Hi @mario, sure thing! :) Any reason for April (as in this exact month)?

@mario
Copy link
Contributor

mario commented Jan 16, 2017

@AndyScherzinger there are quite a few NC Android tasks I have to do before I can revert to sort&filter that are of higher importance at this particular moment, and I don't know how long it'll take me to do all of them - if I do them earlier, sort & filter will come sooner as well, but in that case I'll let you know!

@AndyScherzinger
Copy link
Member

Sounds good @mario! :) Beware though that any changes should be discussed first via a GH issue before implementation is started, just to make sure it will get improved and thus getting merged in the end and not declined ;)

@mario
Copy link
Contributor

mario commented Jan 16, 2017

@AndyScherzinger certainly. You'll get wireframes and all that stuff.

@AndyScherzinger
Copy link
Member

That sounds awesome! Happy to have you on board! 🎉

@ldmpub
Copy link

ldmpub commented Jan 21, 2017

Hi,

In Nextcloud Android app, Alphabetical sort order (A - Z) does not work:
http://dl.free.fr/mSJbHjaLG

@AndyScherzinger
Copy link
Member

@ldmpub which Version are you running, I just checked the latest master and it is working like a charm

@mario any objection for implementing the order ascending/descending issue before April?

@mario
Copy link
Contributor

mario commented Jan 21, 2017

@AndyScherzinger absolutely none - let me know how you want it to look UI-wise and I can make it happen if you want.

@AndyScherzinger
Copy link
Member

@mario I would have gone for the solution Amaze chose: #340 (comment)

any comments/input @eppfel ?

@eppfel
Copy link
Member

eppfel commented Jan 21, 2017

If it not hurts too much, that it might be redone with filter in aprils, go for it! Like it.

@ldmpub Looks very weird. Best would be to open a new issue with more specifics.

@AndyScherzinger
Copy link
Member

Great, then let's go for it! This will add to the usability part :)

@AndyScherzinger
Copy link
Member

@mario preference wise it might already be available but the UI part to set Ascending / descending is missing

@ldmpub
Copy link

ldmpub commented Jan 21, 2017

@ldmpub Looks very weird. Best would be to open a new issue with more specifics.

New issue opened, see #572.

@jancborchardt
Copy link
Member

@AndyScherzinger in the original post up top and the discussions we decided to not do the ascend/descend since it's quite confusing and Z->A or Oldest->Newest doesn't really make sense, does it?

@tobiasKaminsky
Copy link
Member Author

@jancborchardt what if you have 1000 files and want to see the oldest file?
As we do not have a "fast scroll", with which you then could just scroll to bottom nearly immediately, we should support this.
It is only one more button in the sorting options ;-)

@eppfel
Copy link
Member

eppfel commented Jan 22, 2017

The longer the list, the more relevant this use case gets.
But now that I think about it, this adds a tap to the process. Is it possible to introduce ascending /descending as tabs, which changes the options. Therefore we add a tap only to switch and it would be easier to discover what does what.

@AndyScherzinger
Copy link
Member

@eppfel what do you mean by a ascending, descending tab? And where? Wireframe?

@eppfel
Copy link
Member

eppfel commented Jan 22, 2017

Very rough, but that should be understandable. Other options beside name should have small indications (Oldest -> Newest / Newest ->), too.

It was just an idea. I have no idea, if this is easy to implement...

slice2

Tap on descending:

slice1

@ldmpub
Copy link

ldmpub commented Jan 22, 2017

Hi,

I personally find tabs and terms Ascending / Descending very hard to use (double tap) and to understand (is date x ascending compared to date y?).

From my / end-user point of view a simple list is more effective:

  • Last Modified - Older first
  • Last Modified - Newer first
  • Name - A -> Z
  • Name - Z ->A
  • and so on...

@ldmpub
Copy link

ldmpub commented Jan 22, 2017

An other solution is to create this kind of UI (extract from ES File Explorer), same as above but more rich because each 'list' entry has its own icon:
sort suggestion for nexcloud android app

@eppfel
Copy link
Member

eppfel commented Jan 22, 2017

Yeah, I would prefer icons as well. I think the idea was to introduce the capability with a small change. I could come up with a more detailed mock-up, but I don't if it is worth it at this point...

@AndyScherzinger
Copy link
Member

Uuuuuh, I like @ldmpub's solution with icons :)
This would mean a custom pop up but isn't to hard to implement and the currently active could just be tinted NC blue when opened and a simply click on the icon would close the pop up and set the new order. I think that would still be doable in an okay amount of time and with the tinting would support theming out of the box whenever we start with that feature :)

@AndyScherzinger
Copy link
Member

I can start to put up a prototype some time later today based on the icon idea :)

@eppfel
Copy link
Member

eppfel commented Jan 22, 2017

I would still change the axis of @ldmpub's screenshot...

@eppfel
Copy link
Member

eppfel commented Jan 22, 2017

Description left, two icons on the right. Doable?

@AndyScherzinger
Copy link
Member

@eppfel absolutely 👍

@AndyScherzinger
Copy link
Member

For any further discussion, please see/go-to the corresponding PR #575

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 1.5.0 milestone Jan 27, 2017
@AndyScherzinger
Copy link
Member

#575 has been merged to master

@jancborchardt
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants