New sorting order dialog #575

AndyScherzinger · 2017-01-22T23:06:07Z

PR for #340

mario · 2017-01-23T09:07:38Z

Do we even need a cancel? If it's a dialog, any click outside the dialog should cancel it.

AndyScherzinger · 2017-01-23T09:10:34Z

@mario that is correct (and would also work), so we could remove it.

What do you think @eppfel ?

mario · 2017-01-23T10:09:28Z

@AndyScherzinger how do you currently show the selected/default choice? That's not visible in the screenshot you've shown us.

eppfel · 2017-01-23T10:21:57Z

How could we make modification time and size more understandable? The arrow in the icon is not self-explanatory IMO. 🤔

Do we even need a cancel? If it's a dialog, any click outside the dialog should cancel it.

If it does not make the pop-up overflow, I would leave it. Gives the insecure user more control. Worst case: some user chooses sorting out of accident and does not know, he can tap on the background to cancel.

@AndyScherzinger how do you currently show the selected/default choice? That's not visible in the screenshot you've shown us.

I think he wanted to highlight the icon with the nextcloud/theme color. 👍

AndyScherzinger · 2017-01-23T10:53:53Z

How could we make modification time and size more understandable? The arrow in the icon is not self-explanatory IMO.

I just created the icons to have something, happy for any contributions for iconswork :)

@AndyScherzinger how do you currently show the selected/default choice? That's not visible in the screenshot you've shown us.

I think he wanted to highlight the icon with the nextcloud/theme color.

exactly, but that part isn't finished yet, the active one will be tinted with the theme color 😃

eppfel · 2017-01-23T10:57:28Z

I just created the icons to have something, happy for any contributions for iconswork :)

I thought there are defaults in the material icons set. 😁

AndyScherzinger · 2017-01-23T10:59:39Z

I thought there are defaults in the material icons set.

There are none for this, so I created them based on existing material design icons (basically combining the "clock" and "space" with the arrow...)

eppfel · 2017-01-23T11:38:54Z

For size we could use this: sort ic_sort_black_24dp_1x and upside down, instead of the arrow.

Does not make too much sense for time, though...

eppfel · 2017-01-23T11:39:44Z

And "Z over A" would be awesome for the second icon.

AndyScherzinger · 2017-01-23T12:01:28Z

And "Z over A" would be awesome for the second icon.

And the arrow? would that one than have to point down for both?

For size we could use this: sort and upside down, instead of the arrow.

while keeping the "cake" part?

AndyScherzinger · 2017-01-23T12:02:15Z

Screenshot with the tinting active: @eppfel @mario :)

eppfel · 2017-01-23T13:24:32Z

And "Z over A" would be awesome for the second icon.

And the arrow? would that one than have to point down for both?

mh, logically, yes. I guess I have to see to see it.

For size we could use this: sort and upside down, instead of the arrow.

while keeping the "cake" part?

Yes

Hope you're having fun with the icons.. 😆
Font awesome has some different sorting icons: http://fontawesome.io/icons/ -> search "sort"

AndyScherzinger · 2017-01-23T13:54:16Z

mh, logically, yes. I guess I have to see to see it.

@eppfel see screenshot above and below the latest one with the changed size icon:

eppfel · 2017-01-23T18:17:17Z

arrow on A->Z has to be upside down
I would put bigger -> smaller left and smaller -> bigger
make the sort icon bigger in relevance to the cake

AndyScherzinger · 2017-01-23T19:56:49Z

I would put bigger -> smaller left and smaller -> bigger

What would be "bigger" for all three types? (size is the one I understand)

tobiasKaminsky · 2017-01-23T19:59:10Z

maybe it is just my lazy brain...but modification time not clear to me...left is "newest -> oldest"?
maybe something like a triangle is better for this (instead of an arrow)?

AndyScherzinger · 2017-01-23T20:03:00Z

Anybody is welcome to do the icons ;) cc: @jancborchardt

I just put some effort into it to get things started, but I am not *-designer, just want to get this thing done! 🚀

eppfel · 2017-01-23T22:23:50Z

bigger meant only file-size

AndyScherzinger · 2017-01-24T08:31:34Z

@eppfel you mean like this?

attr	#	#
Name	A->Z	Z->A
Modification date	younger->older	older->younger
Size	bigger->smaller	smaller->bigger

And if so, how should the modification date icons be changed? With the triangles like @tobiasKaminsky suggested? And if so is triangle "up" then younger->older or the other way round?

eppfel · 2017-01-24T09:36:00Z

Layout 👍

how should the modification date icons be changed? With the triangles like @tobiasKaminsky suggested? And if so is triangle "up" then younger->older or the other way round?

I would use the sort icon, too: shorter bars = shorter time?

hutber · 2017-03-15T11:02:51Z

Ah, I did not know that. I will be sure to check it out in that case 👍

AndyScherzinger · 2017-03-16T18:28:26Z

@mario @tobiasKaminsky your turn :) Can imho also be merged since 1.4.2 has been released :)

tobiasKaminsky · 2017-03-22T19:37:38Z

src/com/owncloud/android/ui/activity/UploadFilesActivity.java

+                mFileListFragment.sortByName(true);
+                break;
+        }
+    }


Too much headache, but can you extract this part to an external function and re-use it? Cause now it is two times exact the same code @AndyScherzinger

AndyScherzinger · 2017-03-26T11:58:00Z

@mario I also rebased it to latest master, so can we also try to get this back to master, might do a final test today and would then be happy if it can be merged and you could take a final look at the PR.

…lindness

AndyScherzinger · 2017-03-26T21:18:48Z

@mario rebased to latest master and successfully tested it, so I leave the merge to you if you are fine with the change (I know you already approved the PR, but I rebased).

mario · 2017-03-27T05:20:58Z

Merged, thank you for your work.

AndyScherzinger added 2. developing design enhancement medium labels Jan 22, 2017

AndyScherzinger self-assigned this Jan 22, 2017

AndyScherzinger changed the title ~~New sorting order dialog~~ [WIP] New sorting order dialog Jan 23, 2017

AndyScherzinger force-pushed the newSortingLayout branch from 5a51327 to 7cff457 Compare January 23, 2017 13:53

AndyScherzinger mentioned this pull request Jan 23, 2017

Choose sorting order #340

Closed

AndyScherzinger added 3. to review and removed 2. developing labels Jan 23, 2017

tobiasKaminsky reviewed Mar 22, 2017

View reviewed changes

AndyScherzinger force-pushed the newSortingLayout branch 3 times, most recently from dc26bf3 to 036dc48 Compare March 26, 2017 00:18

AndyScherzinger added 15 commits March 26, 2017 16:10

new sorting order dialog

8e884b8

add breaks and empty default to switch

9ebb7d9

default to alphabetical ascending

4a14e0f

wired the new sorting order fragment

d0a6e6e

minor tweaking and fixes for ordering

0490d52

change icons according to review

8c22295

integrate new sorting dialog into Upload file activity

d13d064

remove PreferenceManager dependency and work on input parameters only

b4962da

move image button icon coloring to DisplayUtils

c1867c0

flip arrow according to design review

862efbd

redesign of dialog according to design review/mock/feedback

6086ff8

slightly shorten code

a28a0e9

make actual selection bold, for easier recognition in case of color b…

e0bd3d7

…lindness

replace complex LinearLayouts with table layout for better performance

15b4c8a

move to new folder structure after branding

a5e5cb8

AndyScherzinger force-pushed the newSortingLayout branch from 036dc48 to a5e5cb8 Compare March 26, 2017 14:11

mario merged commit 28aa44b into master Mar 27, 2017

mario deleted the newSortingLayout branch March 27, 2017 05:21

AndyScherzinger removed 4. to release ready for dev labels Apr 19, 2017

jancborchardt mentioned this pull request Apr 30, 2019

Floating files header nextcloud/server#15302

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New sorting order dialog #575

New sorting order dialog #575

AndyScherzinger commented Jan 22, 2017 •

edited

Loading

mario commented Jan 23, 2017

AndyScherzinger commented Jan 23, 2017

mario commented Jan 23, 2017

eppfel commented Jan 23, 2017 •

edited

Loading

AndyScherzinger commented Jan 23, 2017

eppfel commented Jan 23, 2017 •

edited by AndyScherzinger

Loading

AndyScherzinger commented Jan 23, 2017 •

edited

Loading

eppfel commented Jan 23, 2017

eppfel commented Jan 23, 2017

AndyScherzinger commented Jan 23, 2017

AndyScherzinger commented Jan 23, 2017 •

edited

Loading

eppfel commented Jan 23, 2017

AndyScherzinger commented Jan 23, 2017 •

edited

Loading

eppfel commented Jan 23, 2017

AndyScherzinger commented Jan 23, 2017

tobiasKaminsky commented Jan 23, 2017

AndyScherzinger commented Jan 23, 2017

eppfel commented Jan 23, 2017 •

edited

Loading

AndyScherzinger commented Jan 24, 2017 •

edited by eppfel

Loading

eppfel commented Jan 24, 2017

hutber commented Mar 15, 2017

AndyScherzinger commented Mar 16, 2017

tobiasKaminsky Mar 22, 2017

AndyScherzinger commented Mar 26, 2017

AndyScherzinger commented Mar 26, 2017

mario commented Mar 27, 2017

New sorting order dialog #575

New sorting order dialog #575

Conversation

AndyScherzinger commented Jan 22, 2017 • edited Loading

mario commented Jan 23, 2017

AndyScherzinger commented Jan 23, 2017

mario commented Jan 23, 2017

eppfel commented Jan 23, 2017 • edited Loading

AndyScherzinger commented Jan 23, 2017

eppfel commented Jan 23, 2017 • edited by AndyScherzinger Loading

AndyScherzinger commented Jan 23, 2017 • edited Loading

eppfel commented Jan 23, 2017

eppfel commented Jan 23, 2017

AndyScherzinger commented Jan 23, 2017

AndyScherzinger commented Jan 23, 2017 • edited Loading

eppfel commented Jan 23, 2017

AndyScherzinger commented Jan 23, 2017 • edited Loading

eppfel commented Jan 23, 2017

AndyScherzinger commented Jan 23, 2017

tobiasKaminsky commented Jan 23, 2017

AndyScherzinger commented Jan 23, 2017

eppfel commented Jan 23, 2017 • edited Loading

AndyScherzinger commented Jan 24, 2017 • edited by eppfel Loading

eppfel commented Jan 24, 2017

hutber commented Mar 15, 2017

AndyScherzinger commented Mar 16, 2017

tobiasKaminsky Mar 22, 2017

Choose a reason for hiding this comment

AndyScherzinger commented Mar 26, 2017

AndyScherzinger commented Mar 26, 2017

mario commented Mar 27, 2017

AndyScherzinger commented Jan 22, 2017 •

edited

Loading

eppfel commented Jan 23, 2017 •

edited

Loading

eppfel commented Jan 23, 2017 •

edited by AndyScherzinger

Loading

AndyScherzinger commented Jan 23, 2017 •

edited

Loading

AndyScherzinger commented Jan 23, 2017 •

edited

Loading

AndyScherzinger commented Jan 23, 2017 •

edited

Loading

eppfel commented Jan 23, 2017 •

edited

Loading

AndyScherzinger commented Jan 24, 2017 •

edited by eppfel

Loading