Dagger tries to load NContentObserverJob on <5.0

[tobiasKaminsky]

java.lang.NoClassDefFoundError: com.owncloud.android.jobs.NContentObserverJob
        at com.nextcloud.client.di.DaggerAppComponent.getMapOfClassOfAndProviderOfAndroidInjectorFactoryOf(DaggerAppComponent.java:320)
        at com.nextcloud.client.di.DaggerAppComponent.getDispatchingAndroidInjectorOfActivity(DaggerAppComponent.java:323)
        at com.nextcloud.client.di.DaggerAppComponent.injectMainApp(DaggerAppComponent.java:714)
        at com.nextcloud.client.di.DaggerAppComponent.inject(DaggerAppComponent.java:710)
        at com.owncloud.android.MainApp.attachBaseContext(MainApp.java:185)

NContentObserverJob is >=Lollipop and such it is not compiled/accessible on <5.0.

@ezaquarii do you have an idea how to fix this?
Maybe we need two different ComponentsModule, depending on API?

This needs to be fixed before 3.7.0 can be released.

[tobiasKaminsky]

Maybe something like this?
https://stackoverflow.com/questions/34274795/dagger2-is-it-possible-to-inject-based-on-android-version

[ezaquarii]

Yes, this boils down to having an interface that hides a platform specific implementation. This is a way to go with our own code, but it could be a bit tricky for any existing platform-related that does not give much flexibility with subclassing/implementing interface. Android APIs are really badly designed, sadly. I'll check it out this evening and get back to you. Reverting di around this particular class could be a simplest solution for the time being until we roll out a correct fix for this issue. Cheers, Chris

…

On June 14, 2019 7:40:08 AM UTC, Tobias Kaminsky ***@***.***> wrote: Maybe something like this? https://stackoverflow.com/questions/34274795/dagger2-is-it-possible-to-inject-based-on-android-version -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #4147 (comment)

[tobiasKaminsky]

Thanks for this great idea how to solve it.
I was somehow totally blocked and only tried to find a way how to solve it with DI.
I will release a RC4 with this fix at ~24.06., as I am on vacation next week.

[ezaquarii]

I will release a RC4 with this fix at ~24.06., as I am on vacation next week.

Ok, in such case I can possibly supply a proper fix for this mergable when you get back.

[ezaquarii]

I think that optimal solution would be to migrate it to https://developer.android.com/reference/androidx/work/WorkManager

This official library abstracts away platform differences betwen API levels. We could probably also migrate evernote tasks too.

[ezaquarii]

Quick fix: #4171 - I removed dagger DI.

[stale]

This request did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

[stale]

This request did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

[AndyScherzinger]

PR exists

[ezaquarii]

This PR was meant to help push 3.7.0 out of the door only. I'm ok with merging it however, as it has minimal impact anyway.

In longer term I'd rather kill this NContentObserverJob and replace it with latest WorkManager that works on all android api levels.

[tobiasKaminsky]

In longer term I'd rather kill this NContentObserverJob and replace it with latest WorkManager that works on all android api levels.

That is a good way to go.
So we close this and #3147 is about to switch to WorkManager, so we do not forget it.