Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DI from NContentObserverJob #4171

Merged

Conversation

ezaquarii
Copy link
Collaborator

Removing DI from the service fixes DI crash on older
devices when JobService is not provided by the system,
prevending ClassNotFoundException.

A proper fix for this issue must follow.

Signed-off-by: Chris Narkiewicz hello@ezaquarii.com

Removing DI from the service fixes DI crash on older
devices when JobService is not provided by the system,
prevending ClassNotFoundException.

A proper fix for this issue must follow.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
@ezaquarii
Copy link
Collaborator Author

@tobiasKaminsky @AndyScherzinger This should fix 3.7.0 RC3.

@AndyScherzinger
Copy link
Member

/backport to stable-3.7

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
Copy link
Member

I needed to remove those two classes in question also from DI.
I tested it with Android 4.1 and 9.0 and both upload and document storage (last one only on 9.0) are working

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9803.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

306

Lint

TypemasterPR
Warnings5858
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings68
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings137
Total422

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings68
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings120
Security Warnings47
Dodgy code Warnings137
Total422

@AndyScherzinger AndyScherzinger merged commit 908ce74 into nextcloud:master Jun 26, 2019
@backportbot-nextcloud
Copy link

The backport to stable-3.7 failed. Please do this backport manually.

@AndyScherzinger
Copy link
Member

@tobiasKaminsky needs a manual backport, unfortunately I am already afk.

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.8.0 milestone Jun 26, 2019
tobiasKaminsky added a commit that referenced this pull request Jun 27, 2019
908ce74 Merge pull request #4171 from ezaquarii/fix-broken-di-on-older-devices
2e6f09d Merge pull request #4178 from nextcloud/kapt
6f2a994 fix parcelable with using kapt
f83b584 [tx-robot] updated from transifex
752d55f daily dev 20190625
@tobiasKaminsky
Copy link
Member

Backport is in #4186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants