Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use preview endpoint instead of thumbnail #13164

Merged
merged 1 commit into from
Aug 22, 2024
Merged

use preview endpoint instead of thumbnail #13164

merged 1 commit into from
Aug 22, 2024

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Jun 21, 2024

do not use path, but fileid for previews

  • Tests written, or not not needed

Copy link
Collaborator

@alperozturk96 alperozturk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working

@AndyScherzinger
Copy link
Member

should we check that the id is not -1 ?

do not use path, but fileid for previews

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Copy link

Codacy

Lint

TypemasterPR
Warnings6262
Errors33

SpotBugs

CategoryBaseNew
Bad practice6363
Correctness6464
Dodgy code305305
Experimental11
Internationalization77
Multithreaded correctness66
Performance5252
Security1818
Total516516

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13164.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 merged commit c79597f into master Aug 22, 2024
21 of 22 checks passed
@alperozturk96
Copy link
Collaborator

/backport to stable-3.29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants